HTTP 422 when resubmitting a stack with a new bottom branch after merge
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 55/100
Rechercherichtung
Beginne beim Überschreibungsablauf von gh stack submit und der Stack-Ersetzungsanfrage an /repos/org-name/repo-name/stacks/656/unstack; reproduziere die Abfolge des Mergens von branch-a, des Hinzufügens von branch-d und des erneuten Einreichens. Erledigt bedeutet, dass der vorhandene Stack ohne HTTP 422 ersetzt werden kann und GitHub branch-d, branch-b und branch-c widerspiegelt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Summary
When using gh stack, submitting a stack fails if the bottom branch in the stack has been merged and a new branch is subsequently added below the remaining stack.
gh stack submit detects that the local stack has changed and offers to overwrite the existing stack on GitHub, but the overwrite fails because the existing GitHub stack still contains the previously merged branch.
Reproduction
Start with a stack containing three branches:
main
│
▼
branch-a
│
▼
branch-b
│
▼
branch-c
Submit the stack with gh stack submit.
At this point, the GitHub stack looks like:
main
│
▼
branch-a
│
▼
branch-b
│
▼
branch-c
1. Merge the bottom branch
Merge the PR for branch-a into main.
The remaining stack is now effectively:
main
│
▼
branch-b
│
▼
branch-c
2. Add a new branch below the stack
Create branch-d from main and add it to the bottom of the local stack.
The local stack is now:
main
│
▼
branch-d
│
▼
branch-b
│
▼
branch-c
So the local stack has changed from:
main
│
▼
branch-a
│
▼
branch-b
│
▼
branch-c
to:
main
│
▼
branch-d
│
▼
branch-b
│
▼
branch-c
3. Submit the modified stack
Run:
gh stack submit
gh stack detects that the local stack has been modified and asks:
✗ a modify was completed but the stack has not been submitted yet
? The local stack has been modified. Overwrite the existing stack on GitHub? Yes
The submit then fails with:
⚠ Failed to delete existing stack: HTTP 422: Pull request #650 cannot be removed from this stack
(https://api.example.ghe.com/repos/org-name/repo-name/stacks/656/unstack)
Expected behavior
gh stack submit should reconcile the local stack with the existing GitHub stack.
The following workflow should be supported:
Create stack
↓
Submit stack
↓
Merge bottom branch
↓
Add a new branch below the remaining stack
↓
Submit stack again
After submitting, the GitHub stack should reflect:
main
│
▼
branch-d
│
▼
branch-b
│
▼
branch-c
The previously merged branch-a should no longer be part of the stack.
Actual behavior
The submit operation attempts to overwrite the existing GitHub stack, but fails while trying to remove the existing stack:
HTTP 422: Pull request #650 cannot be removed from this stack
This prevents the modified local stack from being submitted.
Possible cause
It appears that merging the bottom branch leaves the existing GitHub stack in a state that cannot subsequently be replaced when a new branch is inserted below the remaining stack.
The problematic sequence appears to be:
Initial GitHub stack:
main
│
▼
branch-a
│
▼
branch-b
│
▼
branch-c
│
│ merge branch-a
▼
Local/GitHub stack:
main
│
▼
branch-b
│
▼
branch-c
│
│ add branch-d below branch-b
▼
Local stack:
main
│
▼
branch-d
│
▼
branch-b
│
▼
branch-c
│
│ gh stack submit
▼
HTTP 422 while removing the existing stack
The error references the top branch (branch-c / its PR), even though the structural change is at the bottom of the stack.
This may indicate that the stack replacement/unstack operation is trying to remove or reorder PRs in an order that is invalid after the original bottom PR has already been merged.
Environment
gh stack:0.1.0- OS:
macOS
Minimal reproduction
Initial:
main
└── branch-a
└── branch-b
└── branch-c
Merge branch-a:
main
└── branch-b
└── branch-c
Add branch-d below branch-b:
main
└── branch-d
└── branch-b
└── branch-c
gh stack submit
→ HTTP 422
The expected result is that the final stack is successfully updated to:
main
└── branch-d
└── branch-b
└── branch-c
- Vorherrschende Sprache
- Go
- Sterne
- 1.5k
- Forks
- 73
- Ø Merge
- 1 T. 8 Std.
- Gemergte PRs (30 T.)
- 7
Beitragsleitfaden
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus github/gh-stack
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 85/100
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 92/100
-
feature request topic: cli - general
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
-
feature request topic: auto-merge
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
-
bug topic: docs
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 68/100
Alle Issues in github/gh-stack
Ähnliche Issues
-
textual definition
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 90/100
geneontology/go-ontology#32653 ·
-
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 75/100
-
needs design
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
-
Priority/High ready-for-agent Severity/Major Type/Bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100