With `register_error_subscriber`, view errors are reported twice: the wrapper by the middleware, and its cause by the error subscriber
Maintainer antworten meist innerhalb von 2 Tagen
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 57/100
- Issue-Typ
- Bug
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Bereich
- backend, observability
Rechercherichtung
Start in Hub#capture_exception and trace how captured markers and Sentry::Utils::ExceptionCauseChain handle exceptions and their causes. The report describes a reproduction using Rails 8.1.4 and sentry-rails 7.1.0; run it with reloading both off and on, then add focused coverage for each order. Done means one event per view error, retaining request context.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Issue Description
With config.rails.register_error_subscriber = true, every exception raised in a view becomes two Sentry issues.
Sentry::Rails::CaptureExceptionscaptures theActionView::Template::Errorand marks that object with@__sentry_captured.ActionDispatch::ExecutorreportsExceptionWrapper#unwrapped_exceptiontoRails.error. For a template error, that's the wrapper'scause.Sentry::Rails::ErrorSubscriberforwards that report. The cause isn't the marked object, soHub#capture_exceptiondoesn't skip it.
The two events have different types and stacks, so they group separately. When reloading is off, as in production, the executor reports outside the middleware's scope, so the second event also has no request URL or transaction. In development, ActionDispatch::Reloader reports the cause first, from inside the scope.
Related, from the other direction: #2931
Reproduction Steps
Below is a single-file app. enable_reloading = false matches production, and setting it to true shows the development order.
require "bundler/inline"
gemfile { source "https://rubygems.org"; gem "rails", "8.1.4"; gem "sentry-rails", "7.1.0" }
require "action_controller/railtie"
EVENTS = []
class ReproApp < Rails::Application
config.root = __dir__
config.eager_load = false
config.enable_reloading = false
config.consider_all_requests_local = false
config.hosts.clear
config.secret_key_base = "x" * 64
config.logger = Logger.new(nil)
routes.append { get "/" => "pages#show" }
end
Sentry.init do |c|
c.dsn = "https://[email protected]/0"
c.transport.transport_class = Sentry::DummyTransport
c.background_worker_threads = 0
c.rails.register_error_subscriber = true
c.before_send = ->(event, hint) { EVENTS << "#{hint[:exception].class} url=#{event.request&.url.inspect}"; nil }
end
class PagesController < ActionController::Base
def show = render(inline: "<%= raise 'boom' %>")
end
ReproApp.initialize!
ReproApp.call(Rack::MockRequest.env_for("/"))
p EVENTS
Output:
["ActionView::Template::Error url=\"http://example.org/\"", "RuntimeError url=nil"]
Expected Behavior
One event per view error, with request context.
Suggested fix
We tested this in the same app: it produced one event with request context, with reloading on and off. In Hub#capture_exception:
- skip capturing when any exception in the
causechain is already marked as captured; - mark the whole chain after capturing.
The event already includes the chain, via Sentry::Utils::ExceptionCauseChain, so a later capture of any part of it duplicates information Sentry already has.
Versions
Ruby 4.0.9, Rails 8.1.4, sentry-ruby / sentry-rails 7.1.0.
Workaround
Leave register_error_subscriber off and subscribe a Rails.error subscriber that forwards only handled: true reports.
- Vorherrschende Sprache
- Ruby
- Sterne
- 990
- Forks
- 552
- Ø Merge
- 2 T. 16 Std.
- Gemergte PRs (30 T.)
- 29
Entwicklungsumgebung
Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus getsentry/sentry-ruby
-
Bug Ruby
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
getsentry/sentry-ruby#3211 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Events dropped client-side for size are only logged at debug level and not recorded as lostEvtl. vergeben @sentry-junior hat das heute übernommen. OffenBug Junior: repro Ruby
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
getsentry/sentry-ruby#3209 · 2 Kommentare · 1 Reaktion ·
Maintainer antworten meist innerhalb von 2 Tagen
-
with_child_span drops spans when blocks exit via break, return, or throwEvtl. vergeben @itsrayeedscodespace hat das vor 1 Tag übernommen. OffenBug Ruby Traces Waiting for: Product Owner
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 38/100
getsentry/sentry-ruby#3206 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
-
Let apps choose how the client IP on events is determinedEvtl. vergeben @sl0thentr0py hat das vor 11 Tagen übernommen. OffenImprovement Ruby
getsentry/sentry-ruby#3180 · 2 Kommentare · 1 Reaktion · 1 zugewiesene Person ·
Maintainer antworten meist innerhalb von 2 Tagen
-
breaking change Next Major
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 58/100
getsentry/sentry-ruby#3176 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 2 Tagen
Alle Issues in getsentry/sentry-ruby
Ähnliche Issues
-
enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 66/100
internetee/registry#2984 ·
Maintainer antworten meist innerhalb von 6 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
ecosyste-ms/issues#862 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Redis Lua error `@user_script:52: ERR value is not an integer or out of range` when `window_size` is configuredEvtl. vergeben @mimosa hat das heute übernommen. Offenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 67/100
riscv/riscv-unified-db#2829 ·
Maintainer antworten meist innerhalb von 1 Tag
-
⛓️ Security Difficulty: Easy Good First Issue Help Wanted ruby Type: Bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
rubyforgood/casa#7404 ·
Maintainer antworten meist innerhalb von 1 Tag