gazebosim/gz-common

Use UTF16 versions of Windows API functions

Offen

#129 geöffnet am 23.11.2020

 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)C++ (59 Forks)auto 404
help wanted

Repository-Metriken

Stars
 (28 Sterne)
PR-Merge-Metriken
 (Durchschn. Merge 9T 6h) (30 gemergte PRs in 30 T)

Beschreibung

Most of ign-common is using the ASCII versions of Windows API functions. These should be converted to the ones using wchar_t (UTF16) strings. The ASCII API is prone to text encoding problems, whereas the UTF16 API doesn't have an issue.

This would probably also deserve a helper function to convert std::string<char> to std::wstring (std::string<wchar_t>). https://stackoverflow.com/questions/4804298/how-to-convert-wstring-into-string might be a good start for this function, as it really isn't as trivial as one would think.

Contributor Guide