MCP client redirect URIs: custom schemes shown as a host, and a change of host case never stored

Offen
#3,442 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
68/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
csharp

Rechercherichtung

Start in src/FluentCMS.Core/Identity/Oidc/ by reading ClientConsents.HostOf and ClientRegistrationService.IsCurrentAsync, then trace the authorize endpoint’s redirect URI comparison. Add tests for custom-scheme consent display and for a host-case-only configuration change taking effect after the next start without ending consents; done when both behaviors pass.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:identity plugin type:bug

Two defects in how redirect URIs of MCP clients are read (src/FluentCMS.Core/Identity/Oidc/), found in the review of #3434. Both are older than it.

  • The consent page shows the authority of a custom-scheme redirect URI as a web host. ClientConsents.HostOf now shows the scheme for com.example.app:/cb, but myapp://callback/x still shows callback as if it were a host.
  • A configured redirect URI changed only in the case of its host is never stored. ClientRegistrationService.IsCurrentAsync treats it as current, so the stored string keeps the old spelling. If the authorize endpoint compares the stored string exactly, a client that sends the URI as it is now configured is refused. Check which comparison the authorize endpoint makes, then store the configured spelling or normalize both sides.

Wanted

  • A custom-scheme redirect shown by its scheme, never as a host, with a test.
  • A configured redirect URI that changes only in case works at the authorize endpoint after the next start, with a test, and without ending consents.

Found in the review of #3434. Bundle 26.

Vorherrschende Sprache
C#
Sterne
567
Forks
107
Ø Merge
1 Std. 19 Min.
Gemergte PRs (30 T.)
353

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus fluentcms/FluentCMS

Alle Issues in fluentcms/FluentCMS

Ähnliche Issues

Weitere Issues zu C#

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.