Add bundled POSIX::strptime support

Offen
#2,163 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
30/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
c, java
Bereich
backend

Rechercherichtung

Start with the upstream POSIX-strptime 0.13 XS source and its test suite, which the issue links, and with t/02-credentials.t in Amazon-Credentials 2.0.1, which requires POSIX::strptime. The main decision is the implementation strategy: FFM calls to libc strptime() need correct struct tm handling, and Windows needs either a compatible implementation or an explicit unsupported result. Done means the unchanged upstream tests and the Amazon-Credentials suite pass on both JVM and interpreter backends.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area:cpan-port enhancement

Summary

Add bundled PerlOnJava support for the CPAN module POSIX::strptime 0.13. Its XS implementation calls the platform C library strptime() and returns the resulting struct tm fields. PerlOnJava currently installs the module's .pm wrapper but cannot load its XS implementation, so applications that rely on it fail at runtime.

Evidence

In CPAN random run 20261121-154046-78188, the dependency install identified POSIX::strptime 0.13 as XS and installed its Perl wrapper without a Java provider. Amazon-Credentials 2.0.1 then failed when require POSIX::strptime reached the unavailable native implementation (t/02-credentials.t). After Module::Loaded was installed and the target retried, the run still reported 3/27 test programs failing and 1/145 subtests failing; the unsupported POSIX::strptime load is one confirmed cause.

The isolated system-Perl oracle passed the Amazon-Credentials 2.0.1 suite: 27 files, 161 tests, with only the two explicitly AWS-dependent tests skipped. The suite uses POSIX::strptime to parse ISO 8601 timestamps.

MetaCPAN reverse-dependency metadata for POSIX::strptime reports 2 released distributions with a required runtime dependency. One is recent (released in the last five years): Amazon-Credentials. The other is EntityModel. Other reverse-dependency records did not meet the released, required-runtime-dependency filter.

The upstream module's XS source and tests are in POSIX-strptime 0.13. Its tests cover time/date directives, unset fields, invalid input and Linux dates before 1900.

Porting scope

  • Add a Java XSLoader provider for POSIX::strptime::strptime, preserving the upstream wrapper, exports and list-return behavior.
  • Match the upstream XS semantics for the nine returned fields: seconds, minutes, hours, day of month, zero-based month, years since 1900, weekday, yearday and DST flag. Preserve undef for fields that upstream marks as unmodified where the platform provides that behavior.
  • Choose and document the implementation strategy. FFM calls to libc strptime() provide the closest macOS/Linux behavior but require correct struct tm ABI handling. Windows has no POSIX strptime() entry point and needs a compatible implementation or an explicit unsupported result matching upstream platform support.
  • Keep locale and timezone behavior aligned with the platform implementation where practical; do not silently report successful parses when the input does not match.

Acceptance criteria

  • Preserve and run the unchanged upstream POSIX-strptime tests under system Perl and PerlOnJava.
  • Add focused project-owned coverage for return-field ordering, undef fields, invalid input, format directives, pre-1900 years and timezone/locale-sensitive cases supported by the implementation.
  • Verify both JVM and interpreter backends.
  • Test or explicitly define behavior on macOS, Linux and Windows, including unsupported platform behavior.
  • Verify use POSIX::strptime qw(strptime) and the fully qualified call used by Amazon-Credentials.
  • Run Amazon-Credentials 2.0.1 against the bundled provider as integration coverage.
Vorherrschende Sprache
Perl
Sterne
67
Forks
8
Ø Merge
4 Std. 36 Min.
Gemergte PRs (30 T.)
123

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus fglock/PerlOnJava

Alle Issues in fglock/PerlOnJava

Ähnliche Issues

Weitere Issues zu Perl

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.