`up`: Compose `build:` service with no Features still builds a label-only stage; put the metadata on the container instead, as for `image:`

Offen

#1,327 erstellt am 13.10.2026 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit: 3/5
Geschätzter Aufwand: 1-2 Tage
Anfängerfreundlichkeit: 45/100

Issue-Typ: Refactoring
Klarheit: Größtenteils klar
Aktivitätsstatus: Aktiv
Tech-Stack: docker, docker-compose, typescript
Bereich: build-system, cli

Rechercherichtung

The condition canAddLabelsToContainer && !imageBuildInfo.dockerfile in src/spec-node/containerFeatures.ts (around line 153) decides whether the label stage is generated. Check how buildAndExtendDockerCompose in src/spec-node/dockerCompose.ts writes the build override. Done when up on a Compose build: service with no Features puts the metadata label on the container and runs a plain docker compose build, and devcontainer build behaves as before.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Identity: TBaltensperger @ nuitio/devcontainer

This comes from nuitio/devcontainer, a private repository that ships a dev-container template on the Compose build: route; the measurements below are from its CI runners.

What happens

With a Docker Compose config whose service uses build: (a Dockerfile) and a devcontainer.json that declares no Features, devcontainer up creating a new container does not run the service's Dockerfile as written. It writes a copy, Dockerfile-with-features, to a temp folder with one more stage that only adds the devcontainer.metadata label, and builds that copy with BUILDKIT_INLINE_CACHE=1.

For an image: service with no Features the CLI skips that stage and puts the metadata on the container as a label (#267). The build: route is left out of that only because of the !imageBuildInfo.dockerfile condition.

Code at v0.89.0 (the latest on npm; these files are unchanged on main at 155f8b2):

No Features: labels go on the container only when there is no Dockerfile; otherwise the label stage is built.
containerFeatures.ts#L152-L160

if (!featuresConfig) {
    if (canAddLabelsToContainer && !imageBuildInfo.dockerfile) {
        return { labels: { [imageMetadataLabel]: JSON.stringify(getDevcontainerMetadata(...).raw) } };
    }
    return { featureBuildInfo: await getImageBuildOptions(params, config, dstFolder, baseName, imageBuildInfo) };
}

The label stage itself, FROM $_DEV_CONTAINERS_BASE_IMAGE AS dev_containers_target_stage plus LABEL devcontainer.metadata=...:
containerFeatures.ts#L199-L217
A build: service always carries imageBuildInfo.dockerfile:
dockerCompose.ts#L167-L184 and
imageMetadata.ts, internalGetImageBuildInfoFromDockerfile
The Compose build override with Dockerfile-with-features and BUILDKIT_INLINE_CACHE=1:
dockerCompose.ts#L197-L246 (inline cache at L230-L234)
docker compose build runs whenever no container exists yet (noBuild = !!container), passing canAddLabelsToContainer = true:
dockerCompose.ts#L394-L399 and
dockerCompose.ts#L267-L297.
For an image: service with no Features the override has no build: section, so this build does nothing.
The labels-on-the-container path already exists for Compose: the labels go into the start override's labels:
(dockerCompose.ts#L411-L412,
#L565-L567), and a later up reads the metadata from the container's labels
(imageMetadata.ts#L441-L445).

Measurement

Dev Containers CLI 0.89.0, Docker 29.8.2, 12-CPU Linux runner. Each figure is the median of three devcontainer up runs that create a new container, timed from --log-level trace. No Features in either config, and every layer of the Dockerfile is cached.

Compose service	`up` total	build step
`image:`	12.7 s	0.4 s (nothing to build)
`build:` (Dockerfile)	14.5 s	3.3 s (range 2.6–4.0 s)

Each new container on the Dockerfile route spends about 3 s more in the build step. Part of that is the cached rebuild of the service's own Dockerfile, which still has to run so that changes to it are picked up. The rest is the generated Dockerfile, the extra stage and the inline-cache export.

Why `build:` was left out, as far as I can tell

In #267, @chrmarti explained the split: LABEL allows larger values than --label (about 1.3 MB against 0.5 MB in testing), so --label is used "when adding metadata is the only reason for using an additional (or modified) Dockerfile". With a Dockerfile there is a build anyway, so the stage looked free. devcontainer build passes canAddLabelsToContainer = false and still bakes the label into the image, which is right.

Nothing in up needs the label on the image: a later up reads it from the container, and the image: route already depends on that. The metadata for a config with no Features is the same size on both routes, so the image: route already accepts the --label size limit.

The stage is not free either. Besides the time, building a generated copy of the Dockerfile from a temp folder causes trouble of its own:

#969: a Dockerfile.dockerignore next to the original Dockerfile is ignored.
#1320: Buildx 0.37.2 bake refuses a Dockerfile that is outside the build context. That report is for devcontainer build with an image: service; this up path generates the same kind of override.

Request

On up, for a Compose build: service with no Features, put the metadata on the container as a label, as for an image: service, and build the service as written with a plain docker compose build, with no generated Dockerfile, no extra stage and no extra build args.

The smallest change I can see: drop && !imageBuildInfo.dockerfile from the condition in containerFeatures.ts#L153. devcontainer build stays as it is, because it passes canAddLabelsToContainer = false. Then buildAndExtendDockerCompose writes no build override for the service, and the existing docker compose build builds the user's Dockerfile unchanged. The single-container Dockerfile route passes false explicitly in singleContainer.ts#L150 and could get the same treatment from up.

If the label size limit is the concern, one option is to keep the stage only when the serialized metadata is close to the --label limit.

Vorherrschende Sprache: TypeScript
Sterne: 3k
Forks: 466
Ø Merge: 13 Std. 28 Min.
Gemergte PRs (30 T.): 2

Entwicklungsumgebung

In Codespaces öffnen

Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.

Kein Dockerfile und keine Docker-Compose-Datei
Keine Pull-Request-Vorlage
Beitragsleitfaden lesen

Erste Schritte

Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
Forken Sie das Repository und arbeiten Sie in einem Branch.
Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus devcontainers/cli

features generate-docs: `$` sequences in NOTES.md and descriptions are expanded as String.replace patterns, splicing the README template into the output
Offen
- Stimmt etwas nicht?
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100

devcontainers/cli#1325 · Erstellt am 08.10.2026

Maintainer antworten meist innerhalb von 1 Tag
README npm install section mentions Python and C/C++ but they are no longer needed
Offen
- Stimmt etwas nicht?
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 92/100

devcontainers/cli#1203 · Erstellt am 14.4.2026

Maintainer antworten meist innerhalb von 1 Tag
test: findUserArg has no unit tests
Offen
- Stimmt etwas nicht?
Schwierigkeit 1/5 1-3 Stunden Anfängerfreundlichkeit 68/100

devcontainers/cli#1178 · 1 Kommentar · Erstellt am 18.3.2026

Maintainer antworten meist innerhalb von 1 Tag
Support Windows container images
Offen
- Stimmt etwas nicht?
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 12/100

devcontainers/cli#1328 · Erstellt am 15.10.2026

Maintainer antworten meist innerhalb von 1 Tag
Feature option values are changed before install.sh sees them: quotes are stripped, and `$…` is expanded or executed
Offen
- Stimmt etwas nicht?
Schwierigkeit 3/5 Ein halber Tag Anfängerfreundlichkeit 45/100

devcontainers/cli#1324 · Erstellt am 08.10.2026

Maintainer antworten meist innerhalb von 1 Tag

Alle Issues in devcontainers/cli

`up`: Compose `build:` service with no Features still builds a label-only stage; put the metadata on the container instead, as for `image:`

Stimmt etwas nicht?

Bewertung

Rechercherichtung

Beschreibung

What happens

Measurement

Why build: was left out, as far as I can tell

Request

Entwicklungsumgebung

Erste Schritte

Mehr aus devcontainers/cli

Stimmt etwas nicht?

Stimmt etwas nicht?

Stimmt etwas nicht?

Stimmt etwas nicht?

Stimmt etwas nicht?

Ähnliche Issues

Stimmt etwas nicht?

Stimmt etwas nicht?

Stimmt etwas nicht?

Stimmt etwas nicht?

Stimmt etwas nicht?

Neue Issues direkt in Ihr Postfach

Why `build:` was left out, as far as I can tell