alter() on PostgreSQL cannot change an attribute: MODIFY is a syntax error, and a comment change is ignored

Offen
#1,625 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 6 Tagen

@dimitri-yatsenko arbeitet bereits daran.

Seit 18.10.2026.

  • #1639 von @dimitri-yatsenko — offen

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
62/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
postgresql, python, sql
Bereich
backend, database

Rechercherichtung

Inspect _make_attribute_alter in declare.py and run the supplied reproduction against PostgreSQL and MySQL to compare the generated SQL. Follow the existing type, nullability, default, rename, and comment comparison paths; PostgreSQL handling must emit backend-specific statements while preserving the core-type marker. Done means all listed PostgreSQL alterations succeed, comment-only changes are applied, and incompatible casts produce a clear error.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug

Summary

On PostgreSQL, Table.alter() can add, drop and rename attributes, but it cannot change one:

  • Changing an attribute's type, nullability or default raises a syntax error. _make_attribute_alter (declare.py) always emits MySQL's MODIFY <column definition>. PostgreSQL needs ALTER COLUMN ... TYPE ..., SET/DROP NOT NULL and SET/DROP DEFAULT.
  • Changing only an attribute's comment does nothing, silently. On PostgreSQL the comment is not part of the column definition: it is applied with COMMENT ON COLUMN. So a comment-only change compares as unchanged, and alter() reports nothing to alter.

MySQL handles all five changes.

Reproduction

DataJoint master, PostgreSQL 15 and MySQL 8.0:

import datajoint as dj

schema = dj.Schema("scratch_alter_pg")


@schema
class Measurement(dj.Manual):
    definition = """
    measurement_id : int32
    ---
    value : float32   # the value
    """


Measurement.definition = """
measurement_id : int32
---
value : float64   # the value
"""
Measurement.alter(prompt=False)
New definition of value MySQL PostgreSQL
value : float64 # the value altered QuerySyntaxError: syntax error at or near "MODIFY" (MODIFY "value" double precision NOT NULL)
value = null : float32 # the value altered same error (MODIFY "value" real DEFAULT NULL)
value = 1.5 : float32 # the value altered same error (MODIFY "value" real NOT NULL DEFAULT '1.5')
reading : float32 # the value {value} (rename) altered altered
value : float32 # another comment altered no change, no message

Expected behavior

On PostgreSQL, alter() makes the same changes it makes on MySQL:

  • a type change becomes ALTER COLUMN ... TYPE ..., with USING where the cast needs it, or a clear error when the backend cannot convert;
  • a nullability change becomes SET/DROP NOT NULL;
  • a default change becomes SET/DROP DEFAULT;
  • a comment change becomes COMMENT ON COLUMN, with the core-type marker kept, so describe() still round-trips.

Repositioning a column has no PostgreSQL equivalent; it is already skipped there (supports_column_position).

Vorherrschende Sprache
Python
Sterne
198
Forks
103
Ø Merge
6 T. 1 Std.
Gemergte PRs (30 T.)
10

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus datajoint/datajoint-python

Alle Issues in datajoint/datajoint-python

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.