[coverage] Conformance findings: METADATA-038
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 55/100
- Issue-Typ
- Bug
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- node.js, typescript
- Bereich
- databases
Rechercherichtung
Start by locating getCrossReference and the SHOW-based foreign-key reshape; the coverage PR diff under tests/ contains the failing test. Compare the reshape with the server-reported updateRule and deleteRule values. Done when reported values are preserved as numeric cells, absent values remain null, and the unrelated-table query returns no rows with the canonical columns.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-nodejs. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-nodejs) is fixed, then flips green as a tripwire.
Findings
- METADATA-038 [sea]: SEA getCrossReference drops server-reported referential-action rules: the SHOW FOREIGN KEYS response carries updateRule/deleteRule (both "3" for a declared FK) but the kernel's SHOW-based FK reshape emits hard-coded NULLs for UPDATE_RULE/DELETE_RULE, so a reported value is discarded instead of being narrowed into the nullable Int16 column; thrift surfaces the same rules correctly
- failing test:
getCrossReference — UPDATE_RULE / DELETE_RULE carry the server's rule values(see the coverage PR diff undertests/)
- failing test:
Reproduce & Expected
METADATA-038 — Validates that the FK (cross-reference) result PRESERVES the referential-action rule codes the server reported, in the canonical UPDATE_RULE / DELETE_RULE columns, and emits NULL — never a synthesize…
Reproduce:
- Phase 1 — call the cross-reference operation for the parent/child FK pair
- Phase 2 — call it for two unrelated tables (no FK between them)
Expected (per the shared spec):
- Both phases complete successfully
- Phase 1 returns at least one FK row
- Phase 1, the core contract. For every FK row, each rule cell agrees with what the server reported on the FK metadata response observed through the proxy (
updateRule/deleteRuleon the SHOW-shaped response,UPDATE_RULE/DELETE_RULEon the native metadata response): a reported value is surfaced, and a field that is absent or null is surfaced as NULL. The driver must not substitute a default rule code for an unreported field, and must not drop a reported one. The two columns are asserted independently — one may be reported while the other is not. Do NOT assert the cells are non-null: a server that reports no rules is conforming. - Phase 1. Every non-NULL cell is a documented JDBC
importedKey*rule code (0..6) — i.e. a narrowed integer, not a truncated or re-interpreted wider value. - Phase 1. Same code space as UPDATE_RULE.
- Phase 1, on surfaces with typed result columns only: the rule columns are a NULLABLE 16-bit integer (JDBC
SMALLINT, ODBCSQL_SMALLINT, ArrowInt16). Surfaces that deliver untyped rows (e.g. Node.js plain objects) satisfy this structurally with a numeric-or-null cell. - Phase 1 negative control — unchanged by this case. PK_NAME carries the server's PK constraint name or NULL; it is never synthesized and never an empty string.
- Phase 2 returns zero rows for the unrelated pair (no error).
- Phase 2. An empty FK result still reports the full canonical cross-reference column set — UPDATE_RULE / DELETE_RULE included — so the rule columns are part of the schema contract, not an artifact of there being rows. Surfaces with their own standardised FK layout (ODBC
SQLForeignKeys) assert that layout's canonical column set in its own order.
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-sql-kernel/pull/381 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-nodejs; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1741
- Vorherrschende Sprache
- TypeScript
- Sterne
- 37
- Forks
- 52
- Ø Merge
- 1 T. 47 Min.
- Gemergte PRs (30 T.)
- 10
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus databricks/databricks-sql-nodejs
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
databricks/databricks-sql-nodejs#541 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
databricks/databricks-sql-nodejs#526 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
databricks/databricks-sql-nodejs#503 ·
Maintainer antworten meist innerhalb von 1 Tag
-
engineer-bot
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 64/100
databricks/databricks-sql-nodejs#274 · 1 Kommentar · 1 Reaktion ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 55/100
databricks/databricks-sql-nodejs#540 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in databricks/databricks-sql-nodejs
Ähnliche Issues
-
refactor
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
tomnewport/memprot-topo#55 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
WalletConnect/walletconnect-monorepo#7368 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 72/100
BU-Spark/se-chem-apll#47 ·
-
embed: handleTurboSignMessage header comment says the signing page posts to '*' (it never does)Offendocumentation
Schwierigkeit 2/5 Unter einer Stunde Anfängerfreundlichkeit 82/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 Ein halber Tag Anfängerfreundlichkeit 70/100
udistrital/paginaweb_root#23 ·