flaky: atlas-host pty::tests::a_title_* fail on loaded Linux CI runners

Offen
#549 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
72/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
rust
Bereich
cli, testing

Rechercherichtung

Start with crates/atlas-host/src/pty/tests.rs, especially the two failing title tests around lines 545 and 569, and inspect how they wait for the shell to exit and collect pty_title events. Run these tests repeatedly under load to reproduce the timing failure. Done when the tests reliably observe the expected title events with a deadline and pass in the Linux CI run.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area: terminal os: linux type: bug

atlas-host pty::tests::a_title_* fail intermittently on the Linux CI runner (Rust (Linux)), unrelated to the PR under test. A rerun of the failed job passes.

Evidence

  • Run 44101988098 (PR #461, head eb47a231), job 134104287831: FAIL atlas-host pty::tests::a_title_that_returns_to_an_earlier_value_is_a_change, at crates/atlas-host/src/pty/tests.rs:569:
    assertion left == right failed left: ["x"] right: ["x", "y", "x"]. The rerun of the same head passed.
  • Run 44104330309 (PR #487, head 2d01391f), job 134114260709 (Linux): FAIL atlas-host pty::tests::a_title_repeated_by_the_program_is_pushed_once at tests.rs:545. The rerun passed.
  • Frequency: 2 failures in the roughly 8 Rust (Linux) attempts I watched on 2026-11-17, while the runners were heavily queued (many PRs at once). Both ran in the full nextest run (4171 tests, 4 threads), not alone.

Suspected cause (not verified)

Both tests drive a shell that prints OSC titles 20 ms apart (sleep 0.02) and rely on each landing in its own 8 ms coalescing window of the pty reader, then call until_exited and read pty_title events with try_recv. On a loaded runner a 20 ms sleep can stretch, or the reader can drain two OSCs in one window, or the exit can be observed before the last pushes are flushed; the failure shows only the first title arriving (["x"]). The tests wait for the process to exit, not for the expected number of titles. Waiting for the expected events (with a deadline) instead of a fixed sleep and a post-exit drain would remove the timing dependency.

No fix in the PRs where it was seen.

Vorherrschende Sprache
Rust
Sterne
3
Forks
1
Ø Merge
9 Std. 51 Min.
Gemergte PRs (30 T.)
310

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus codeatlasdev/atlas

Alle Issues in codeatlasdev/atlas

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.