ci: Rust (Windows) job intermittently lost the runner after 50 min (8 times since 2026-11-15)
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 55/100
- Issue-Typ
- Bug
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- github-actions, rust
- Bereich
- ci-cd, testing-qa
Rechercherichtung
Start by reading atlas_core::sys::kill_tree and its Windows descendants and force_kill logic, then trace the callers crew::proc::run_bounded and crew::engine::TurnProc. The issue identifies the suspected process ID reuse bug and describes a proposed fix; done means applying that fix and checking whether the Windows runner losses continue. If they do, add step timeouts and log upload as the issue suggests.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
What
The job Rust (Windows, full workspace) (ci.yml → rust-gate, cargo nextest on windows-latest) sometimes never finishes: it ends exactly 50:00 min after it starts with the annotation "The hosted runner lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.". No log is kept for the job (BlobNotFound), the Run ./.github/actions/rust-gate step is in_progress forever. A normal run takes 5–9 min; a rerun of the same commit passes.
Evidence (observed)
Scan of every ci.yml run since 2026-11-01 (631 Windows jobs that completed, via gh api .../actions/runs/<id>/jobs):
| started (UTC) | run | head | what |
|---|---|---|---|
| 11-15 01:00 | 43660731836 | af11513b | PR |
| 11-15 04:09 | 43675462339 | 08a6ccd2 | PR |
| 11-15 22:53 | 43771698009 | 0e292a3c | PR #460 (diff: one taskcache test file) |
| 11-16 11:17 | 43854338812 | 4303661f | main dispatch (#424 merge) |
| 11-16 14:22 | 43885042374 | e041082a | PR perf/lazy-hidden-webviews (desktop-only diff) |
| 11-16 21:34 | 43961249893 | d26c1780 | PR #514 |
plus the first attempts of #507 (6a92ff64, 20:21) and #512 (962e4e78, 21:31) that were overwritten by their reruns: 8 incidents.
- None before 2026-11-15 01:00 UTC in 316 earlier jobs; 6 of the 319 after (about 2 %). Every hung head contains
76eee2ce(#335) and the batch merged with it (21:50–21:57 -03 on 11-14: #332, #335, #338, #341, #342, #344, #345, #334, #327); the hung heads' diffs against main are unrelated to each other, so the cause is in main's code, not in a PR. - The runner image (
windows-2025-vs2026), runner (2.338.2) and Hosted Compute Agent (20261103.629) are the same in good and bad runs (logs of successful runs on 11-14, 11-15, 11-16): not an image rollout. - #424 is not the cause: its first hang (
0e292a3c,af11513b,08a6ccd2) predates it, and almost all of its tests arecfg(unix).
Suspect (code defect proven by reading; link to the runner loss is inferred)
atlas_core::sys::kill_tree(root) on Windows (used by crew::proc::run_bounded, crew::engine::TurnProc, the pty control, the language servers):
- it called
descendants(root, rows)which didborn(p) = start_time_secs(p).unwrap_or(0). For a root that has already exited (callers end the tree afterwait_with_output)born(root)was 0, so every process whose recorded parent pid equals that number passed theborn(child) >= born(parent)guard. Windows keepsppidafter the parent ends and reuses pids: any older process whose original parent had the same number (the CI runner's own children are such candidates) was killed withTerminateProcess; force_kill(root)was also called on a pid whose process had ended: afterrun_boundedconsumed the child (wait_with_output) its handle was closed and the number belongs to the next process.
#335 (TurnProc::kill_tree) and #352 (run_bounded → Tree::kill, git/gh calls of the crew) added these callers on Windows around the first incident. Precedent: #223 (kill_uid ending every process of the runner's user).
Not proven: no log of a hung job survives, so it is not known which process was ended, and which test ran. The Windows-visible tests that reach these callers are crew::project, crew::runner::github, gitrun, the pty/hostd Windows tests and the lsp server unit tests (most crew tests are cfg(unix)).
Other candidates checked (not the cause)
Every other kill in the workspace that a Windows test can reach acts on a pid its test spawned or one verified by name/start time (kill_orphans, kill_prior, retire_hostd, hygiene::reap start-time recheck, tunnel adopt is_ssh_name, cleanup_lock, desktop_agent::terminate is unix-only); port_conflict's fake pids only reach classify, never a kill; hostd_windows.rs waits are bounded (ping -n 30/60, timeouts).
Fix
PR: root without a creation time has no tree; caller and its ancestors never in a tree; run_bounded keeps the child's handle until it ended the tree. If the 50-minute losses continue after this, the next step is a step-level timeout-minutes and nextest --no-capture log upload on the Windows job so a loss leaves a log.
Separate failure, same day
runtime::port_conflict::tests::a_holder_in_our_pid_tree_is_own_and_anything_else_is_foreign on PR #514: classify treats pid == std::process::id() as own, the test calls 900 "somebody else's"; Windows pids are small multiples of 4, so a test process numbered 900 fails line 128 (the 900 assertion, which only fails when pid == own pid). Fixed in the same PR (classify_as(me, …)).
- Vorherrschende Sprache
- Rust
- Sterne
- 3
- Forks
- 1
- Ø Merge
- 9 Std. 51 Min.
- Gemergte PRs (30 T.)
- 310
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus codeatlasdev/atlas
-
type: bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 75/100
codeatlasdev/atlas#597 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: ci os: linux type: bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
codeatlasdev/atlas#496 ·
Maintainer antworten meist innerhalb von 1 Tag
-
area: ci type: bug
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 68/100
codeatlasdev/atlas#596 ·
Maintainer antworten meist innerhalb von 1 Tag
-
os: linux type: bug
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 68/100
codeatlasdev/atlas#591 ·
Maintainer antworten meist innerhalb von 1 Tag
-
flaky: Windows scripts job hits test timeouts (check-dco, i18n runner/translate, check-changed)Offenarea: ci os: windows type: bug
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 56/100
codeatlasdev/atlas#550 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in codeatlasdev/atlas
Ähnliche Issues
-
marketing
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 76/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 74/100
kinqsradio/orbyn-engineering#729 ·
-
Plans page scenario races Shift+Tab against the plan list being drawn again in Firefox and WebKitOffenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 83/100
nledford/Ladderback#1091 ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug fix packaging ui user-sprint
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Vondor/KassenSturz#1197 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
Maintainer antworten meist innerhalb von 1 Tag