fix(telemetry): classify remaining expected failures in Sentry

Offen
#50 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
32/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
observability

Rechercherichtung

Start with docs/telemetry.md and tests/telemetry.test.ts to see how expectedOutcome is defined and asserted, then audit each named Sentry group against the code that emits it, e.g. src/server/baguette-runtime.ts:77, src/ui/simulator-panel.ts:868, and the serve-emu/UI discovery paths. Check the 5 s simctl launchctl list deadline before filtering device-apps timeouts. Done means every listed failure has a classification, metric, or sample decision and the telemetry docs and tests match.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement

Commit 44f1b66 added expectedOutcome, but these user-environment and host-lifecycle failures are still not classified, so they keep being reported as errors. Each one should map to an expected outcome, be counted as a metric, or be sampled.

Toolchain missing (unsupported_platform or a new toolchain_missing)

  • Baguette Swift runtime libraries (src/server/baguette-runtime.ts:77): 3T, 2V
  • spawn /usr/bin/xcrun ENOENT: 9S, likely also 8Q (ios.devices.discovery, 69 users)
  • devicectl "requires Xcode 27": 4E, 21

Device-apps discovery deadlines

  • termination === "deadline" is deliberately left unclassified: 2N (ios_simulator_apps, 108 users), 3W, 61, 4V, 3C
  • Before filtering, check whether the 5 s simctl launchctl list limit is too tight. Consider raising it to about 15 s.
  • The same applies to UI discovery timeouts: UI-P

Physical iOS connection state (device_unavailable)

  • ios_physical_* causes connection_failed, connection_timeout, service_open_failed, service_open_timeout, query_timeout: 4B, 2W, 43
  • "iPhone no longer connected": 7P
  • "Connect the paired iPhone": 22
  • "adapter closed": 7V

Other server errors

  • Processes killed by signal (process_signalled → cancelled): AD, AC
  • adb timeouts and offline devices in serve-emu (device_unavailable): 7
  • ServeEmu.device: 1Q
  • Screenshot HTTP 400 (device_unavailable): 2T
  • Display FPS requires Android 12 (unsupported_platform): 9Y; FPS monitor already exists (invalid_input): 9F
  • "no accessibility data": 39, R. Also route plugin.ts:321 through describeUi so it gets the existing restart recovery.
  • tvOS or no-bezel simulators, definition.json 404 (unsupported_platform, fall back to no bezel): 29, 8X
  • Generic TimeoutError on tool deadlines (count as a metric, keep sampled): 2X, 36, X
  • app_flow "No package.json found" (invalid_input): A2

UI / host lifecycle

  • host_unavailable / session_closed outcomes:
    • UI-15, "app-server process is not available"
    • UI-12, "Transport closed"
    • UI-2X, "MCP client is shut down"
    • UI-2T, "composer unavailable"
    • UI-1F, "MCP app identity changed"
  • Best-effort cleanup calls that time out (*_close, *_reset, mobile_check_plugin_update, mobile_logs_close) should be counted as metrics, not captured as exceptions:
  • Small fixes while you're in there:
    • Guard setPointerCapture (src/ui/simulator-panel.ts:868, UI-2W)
    • Handle EPIPE on writes to a closed helper in resources.read (SERVER-A4)

Update docs/telemetry.md and tests/telemetry.test.ts to match.

Vorherrschende Sprache
C++
Sterne
243
Forks
21
Ø Merge
15 Std. 6 Min.
Gemergte PRs (30 T.)
57

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus callstackincubator/codex-mobile-dev-plugin

Alle Issues in callstackincubator/codex-mobile-dev-plugin

Ähnliche Issues

Weitere Issues zu C++

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.