close: stop a simulator or emulator that the session's open booted

Offen
  • Stimmt etwas nicht?
#4,162 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
35/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
android, ios, typescript
Bereich
backend, cli, mobile-dev

Rechercherichtung

Start with markSelectionBootOccurred in packages/device-selection/src/device-selection-resolver.ts to see where the boot fact is set, then trace how the session stores it and where the close path is handled in the daemon. The close help in packages/command-surface/src/management/app.ts and the shutdown policy (ADR 0029) show what else changes. Done means the daemon tests for boot-owned, pre-booted and policy-denied closes pass, and a live open-then-close leaves the device in the expected state. Resolve the open decisions with a maintainer before you start.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement

Purpose

Agents leave local simulators and emulators running after they finish. open boots a stopped device on its own (ensureBootedSimulator and the Android boot path), but close only stops the device with an explicit --shutdown. An overnight agent run on one host left many booted simulators behind. In that run, 42 close requests and zero close --shutdown requests were logged.

The daemon already knows when open booted the device: markSelectionBootOccurred in packages/device-selection/src/device-selection-resolver.ts sets selection.bootOccurred: true. No close or teardown path uses that fact.

The rule is "leave the device as you found it". If a session's open booted a local simulator or emulator, close stops it. If the device was already running, close leaves it running.

Required behavior

  • The session records whether its open booted the local virtual device. Provider and physical targets never record a boot (this matches markSelectionBootOccurred).
  • If the session booted the device, plain close stops it through the same shutdown capability as close --shutdown. This applies to every local simulator and emulator: iOS, tvOS, visionOS, watchOS, and Android.
  • If the device was already booted before open, plain close leaves it running. This is the current behavior.
  • close --shutdown keeps its current meaning: it always stops a local simulator or emulator.
  • Daemon policy that denies device-shutdown (ADR 0029) also blocks the implicit stop. In that case close succeeds and reports that the device was kept running.
  • The close response reports the implicit stop in data.shutdown, the same as an explicit --shutdown.
  • A boot-owned device does not keep a warm iOS runner after close, because the device stops.

Open decisions

  • Should there be an opt-out for an agent that booted a device and wants it to stay up (for example close --keep-device)? A new flag follows docs/agents/cli-flags.md.
  • Should graceful daemon shutdown, or session idle expiry, also stop devices that its sessions booted? That would cover agents that never call close.

Completion conditions

  • Daemon tests: a session that booted a simulator or emulator stops it on plain close. A session on a device that was already booted does not stop it. Policy denial keeps the device running and close still succeeds.
  • Live check on a stopped iOS simulator and a stopped Android emulator: open then close, and the device ends shut down. With a pre-booted device, it ends booted.
  • Update the help and docs to describe the new default: close help in packages/command-surface/src/management/app.ts, the lifecycle facts and workflow/manual-qa/validate topics in src/commands/schema/cli-help*.ts, website/docs/docs/sessions.md, and the skills. The interim instructions that tell agents to add --shutdown can then become plain close.
  • Changelog/release note entry for 0.22, because the default changes.
Vorherrschende Sprache
TypeScript
Sterne
5.2k
Forks
359
Ø Merge
13 Std. 23 Min.
Gemergte PRs (30 T.)
655

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus callstack/agent-device

Alle Issues in callstack/agent-device

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.