[FEATURE]: code action to fix spelling of all occurences of the symbol?

Offen
#153 1 Kommentar 3 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
5/5
Geschätzter Aufwand
Über eine Woche
Anfängerfreundlichkeit
24/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Veraltet
Tech-Stack
python, rust
Bereich
devtools

Rechercherichtung

Start by reading the code action implementation and the discussion in issue #150; the issue does not name relevant files or tests. Check how Codebook represents spelling corrections and whether the LSP integration supports symbol rename actions. Done means a correction can offer a rename for all occurrences when another LSP provides that capability.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement feedback needed
Feature Description

#150 explains why Codebook typically flags only definitions - this makes a lot of sense.

Wondering then if it would be possible to have a code action that uses another LSP, if present, to rename symbol - not just change this specific spelling. No idea though if "code action calling the code action of another LSP" is technically doable, and / or if this is somehow standardized (do LSP have a standard "rename symbol" tag or name on the corresponding code action? or is it free for all?).

Use Case
def this_hhas_a_typo():
    print("typo!")

this_hhas_a_typo()

if the typo is highlighted in the def line, it would be great to provide a code action to "rename all symbol occurences"; this is typically provided by space-r in helix across programming language LSPs, so I suppose this may be somehow standardized?

Proposed Solution

If possible, have a "mirror" code action for each possible spelling correction that is "replace all symbols by ..." instead of "replace by ..."

Alternative Solutions

For now the user can get the diagnostic, decide what to use, and apply the LSP-based symbol rename themselves by typing themselves what to replace with.

Examples

No response

Additional Context

No response

Vorherrschende Sprache
Rust
Sterne
925
Forks
59
Ø Merge
53 Min.
Gemergte PRs (30 T.)
10

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus blopker/codebook

Alle Issues in blopker/codebook

Ähnliche Issues

Weitere Issues zu Rust

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.