[Refactor][CI] Publish the lake-builder image with the project's Docker Hub credentials instead of a manual tag
Maintainer antworten meist innerhalb von 3 Tagen
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 35/100
- Issue-Typ
- Refactoring
- Klarheit
- Größtenteils klar
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- docker, docker-compose, github-actions, go
- Bereich
- ci-cd, devops, infrastructure
Rechercherichtung
Read .github/workflows/build-builder.yml and compare its credentials and triggers with .github/workflows/build.yml; inspect devops/docker/lake-builder/Dockerfile and the five workflow image references named in the issue. First confirm with maintainers which Docker Hub target to use, since the proposal depends on that decision. Done when the builder image publishes with project credentials on the stated triggers and all five CI jobs consume a pinned tag.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
What and why to refactor
Five CI jobs run inside mericodev/lake-builder:latest:
test.yml (unit-test), test-e2e.yml (mysql and postgres),
golangci-lint.yml and migration-script-lint.yml.
That image is out of date and, as far as I can tell, can no longer be
refreshed through the intended path:
| Fact | Source |
|---|---|
mericodev/lake-builder:latest is v0.0.15, pushed on 2023-06-30, amd64 only |
Docker Hub API |
It was built from the Dockerfile of that time: debian:bullseye, golang:1.20.4, libgit2 1.3.2, python:3.9-slim-bullseye |
git show f29d31451:devops/docker/lake-builder/Dockerfile |
The only publishing path is build-builder.yml, triggered by a builder-* tag. The newest such tag is builder-v0.0.7 (2022), so v0.0.8–v0.0.15 were pushed outside this workflow |
git ls-remote --tags origin 'builder-*' |
build-builder.yml logs in with DOCKER_REGISTRY_USERNAME / DOCKER_REGISTRY_PASSWORD and pushes to the company namespace mericodev; no run of it is visible in the Actions history |
workflow file, Actions API |
The CI copes by re-installing the toolchain on every run
(install-libgit2.sh, install-go.sh, install-mockery.sh), so the jobs pass,
but:
- each job rebuilds what the image should already contain;
- changes to
devops/docker/lake-builder/Dockerfile(most recently #9203,
and the Go/mockery bump in #9208) are never exercised by the upstream CI; - the base layers (bullseye, Python 3.9) are past or close to end of life.
Simply pushing builder-v0.0.16 may not help: it depends on credentials for a
non-ASF namespace whose validity I cannot check from outside.
Describe the solution you'd like
The repository already has working Docker Hub credentials:
build.yml logs in with DOCKERHUB_USER / DOCKERHUB_TOKEN and pushes to
${{ secrets.DOCKERHUB_OWNER }}/devlake on every push to main (last
successful runs on 2026-10-11). It already publishes auxiliary, non-release
tags there as well (devlake:amd64-builder, :base, :build-cache-*).
Proposal, in two small PRs:
- Publish — change
build-builder.ymlto- use the same secrets as
build.yml; - run on
pushtomainwhendevops/docker/lake-builder/**(or the
workflow itself) changes, plusworkflow_dispatch— no manual tag needed; - push to the ASF namespace, either as a tag in the existing repository
(e.g.apache/devlake:lake-builder-<short-sha>, following the
amd64-builderprecedent) or to a newapache/devlake-builder
repository, if you prefer that and it can be created.
- use the same secrets as
- Consume — once the first image exists, point the five
container:
lines to the pinned new tag instead ofmericodev/lake-builder:latest.
This also completes the idea of #5041 ("push the lake builder to … apache
dockerhub"), which was closed by the stale bot without a change.
I have validated the current Dockerfile on my fork: its CI builds the builder
image from devops/docker/lake-builder/Dockerfile and runs unit, lint and e2e
(MySQL, PostgreSQL) inside it — all green
(run, with the
changes from #9208).
Questions for the maintainers:
- Is moving the builder to the project's Docker Hub credentials acceptable,
and which target do you prefer: a tag inapache/devlakeor a separate
apache/devlake-builder? - Alternatively, if the
mericodevcredentials are still valid and you prefer
the existing path: could someone push abuilder-v0.0.16tag onmain?
I'm happy to open the PRs for option 1 once the direction is clear.
Related issues
- #5041 — push the lake builder to the Apache Docker Hub (closed as stale)
- #4805 — base images and automated image builds (closed as stale)
- #9203 — made the lake-builder image rebuildable again (bookworm, Go from go.dev)
- #9208 — Go 1.26.9 / mockery 3.8.1, including the lake-builder Dockerfile
Additional context
The latest policy discussed in #4805 (only update latest for formal
releases) is not affected: the proposal uses explicit, pinned tags for the CI
image and does not touch the release images.
- Vorherrschende Sprache
- Go
- Sterne
- 3.2k
- Forks
- 819
- Ø Merge
- 2 T. 21 Std.
- Gemergte PRs (30 T.)
- 46
Entwicklungsumgebung
Startet den Dev-Container des Projekts im Browser, mit Ihrem eigenen GitHub-Konto.
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Kein Beitragsleitfaden
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus apache/devlake
-
[Bug][e2e] Several plugin e2e tests fail on a fresh database because they depend on tables created by other testsEvtl. vergeben @chenwei791129 hat das heute übernommen. Offen
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 35/100
Maintainer antworten meist innerhalb von 3 Tagen
-
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 15/100
Maintainer antworten meist innerhalb von 3 Tagen
-
Schwierigkeit 3/5 Ein halber Tag Anfängerfreundlichkeit 62/100
Maintainer antworten meist innerhalb von 3 Tagen
-
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 42/100
Maintainer antworten meist innerhalb von 3 Tagen
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 55/100
Maintainer antworten meist innerhalb von 3 Tagen
Ähnliche Issues
-
docs: clarify gh api -f vs -F and @-file expansion in the gh skillEvtl. vergeben @MatiasOlivera hat das heute übernommen. Offenenhancement
Schwierigkeit 2/5 Ein halber Tag Anfängerfreundlichkeit 62/100
cli/cli#14701 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 88/100
aws/aws-advanced-go-wrapper#612 ·
-
Say in the changelog that the text-index update cannot be rolled backEvtl. vergeben @praetorianer777 hat das heute übernommen. Offen
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 88/100
praetorianer777/GoTome#275 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
SAP/crossplane-provider-btp#1118 ·
Maintainer antworten meist innerhalb von 1 Tag
-
benchmark: `make setup` fails because audit-exporter builds with Go 1.25.0 while go.mod requires 1.26.0Evtl. vergeben @xsvm hat das heute übernommen. Offen
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 84/100
volcano-sh/volcano#6097 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag