tui: Shift+P becomes lowercase p in embedded Lazygit

Offen
#65,345 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
42/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
cli

Rechercherichtung

Start from the embedded-terminal input path in the TypeScript TUI: find where PTY input bytes from Ctrl+X then t are translated before reaching lazygit, and compare against the raw reader that already received 70 50 correctly. Reproduce with the scripted PTY (TERM=xterm-256color, literal bytes 70 50) and with TCELL_KEYBOARD_PROTOCOL=legacy lazygit as the working control. Done means p then Shift+P lands as pP in the commit-message field without the legacy env var.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

area/tui platform/linux status/repro-simulated type/bug version/v2
Description

In OpenCode’s embedded terminal, Lazygit receives Shift+P as lowercase p. On the main screen this triggers Pull instead of Push. In the commit-message field, typing p and then Shift+P inserts pp instead of pP.

Plugins

None in the isolated reproduction (--standalone with fresh XDG directories).

OpenCode version

2.3.2

Steps to reproduce
  1. Open OpenCode in a Git repo with at least one staged change. Use an existing session and press Ctrl+X, then t, to open the embedded terminal.
  2. Run lazygit (reproduced with 0.66.3).
  3. In the Files panel, press c to open the commit-message field.
  4. Type p, then Shift+P. The field contains pp; it should contain pP. Press Esc to cancel without committing. No remote is required for this test.
Screenshot

In an isolated PTY, sending literal bytes 70 50 (pP) produced pp in Lazygit inside OpenCode and pP in Lazygit directly. A raw input reader inside OpenCode also received 70 50 correctly. Launching Lazygit inside OpenCode with TCELL_KEYBOARD_PROTOCOL=legacy lazygit preserved pP for the same input. This suggests a keyboard-protocol compatibility issue; the exact layer that drops the uppercase character is unconfirmed.

Operating System

Linux 6.18.64, x86_64; zsh on the host.

Terminal

Ghostty/tmux on the report machine. The isolated reproduction also worked in a scripted PTY with TERM=xterm-256color, outside the live Ghostty/tmux session.

Vorherrschende Sprache
TypeScript
Sterne
227k
Forks
30.7k
Ø Merge
3 Std. 57 Min.
Gemergte PRs (30 T.)
484

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus anomalyco/opencode

Alle Issues in anomalyco/opencode

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.