fix(cli): codex MCP install throws on Windows

Offen
#1,308 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
72/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
typescript
Bereich
cli

Rechercherichtung

Start with the named install-config use case and MCP launch transform, then inspect the existing Windows launch tests and add the Codex case described in the issue. Reproduce with a Codex profile, Windows platform, and an MCP source containing an npx server. Done means installation does not throw and the written TOML contains the Windows launch using cmd with /c and npx.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Description

Installing MCP servers for Codex on Windows throws. The Windows launch rewrite parses its input as JSON, but Codex's MCP content has already been converted to TOML by the tool transform.

Affected file(s)
  • next: cli/src/contexts/framework/application/install/install-config-use-case.ts (applyTransforms: capability.transform(rawContent) then win32Transform(toolContent)), cli/src/contexts/tools/domain/mcp-launch-command.ts (transformMcpForWin32 runs JSON.parse(content)), cli/src/contexts/tools/domain/capabilities/mcp-capability.ts (transform returns mcpJsonToToml for format: "toml"), cli/src/contexts/tools/domain/profiles/codex/profile.ts. Reached from cli/src/contexts/framework/application/restore/generate-tool-distribution-use-case.ts.
  • refactor/cli-target: cli/src/contexts/installation/application/install/install-config.ts (applyTransforms), cli/src/contexts/tools/domain/sections/mcp-section.ts (transformMcpForWin32, launchTransformFor), cli/src/contexts/installation/application/restore/generate-tool-distribution.ts.
Expected behaviour

On Windows, a Codex install with MCP servers succeeds and npx, uvx and uv launches are rewritten for Windows (or knowingly left alone for TOML).

Observed behaviour

JSON.parse throws on the TOML text: Unexpected token 'm', "[mcp_server"... is not valid JSON. The existing Windows cases only cover JSON-format tools, no Codex case exists.

AI tool

Codex

aidd-cli version

unreleased, next

OS

Windows

Additional context

Red-first test: install-config with the Codex profile, a win32Platform and an MCP source containing an npx server. It must not throw, and the written TOML must carry the Windows launch (cmd with /c, npx) for the server. Fix direction: apply the launch rewrite before the format conversion, or have it handle TOML. Decide which, then pin it with the case.

Vorherrschende Sprache
TypeScript
Sterne
481
Forks
45
Ø Merge
1 T. 13 Std.
Gemergte PRs (30 T.)
91

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus ai-driven-dev/framework

Alle Issues in ai-driven-dev/framework

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.