[Bug]: v0.3 JSON-RPC `tasks/pushNotificationConfig/delete` succeeds with no `result` member

Offen
#1,480 0 Kommentare 0 Reaktionen 2 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 2 Tagen

@rohityan arbeitet bereits daran.

Seit 16.11.2026.

  • #1481 von @saquibjawedbit — offen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Beschreibung

What happened?

With enable_v0_3_compat=True, a successful v0.3 tasks/pushNotificationConfig/delete is answered with

{"id": 1, "jsonrpc": "2.0"}

There is no result and no error. JSON-RPC 2.0 §5 says "result: This member is REQUIRED on success" and "Either the result member or error member MUST be included" (https://www.jsonrpc.org/specification#response_object). The v0.3 A2A schema says the same for this method: DeleteTaskPushNotificationConfigSuccessResponse requires result, with type null. The SDK's own v0.3 model, a2a.compat.v0_3.types.DeleteTaskPushNotificationConfigResponse, rejects the body.

The v1.0 binding already gets this right: DeleteTaskPushNotificationConfig answers {"result": null, "id": 1, "jsonrpc": "2.0"}.

Root cause: JSONRPC03Adapter._process_non_streaming_request dumps the whole response envelope with exclude_none=True. That is meant to drop unset optional fields inside the result. For delete, the result itself is None, so the result key is dropped too:

https://github.com/a2aproject/a2a-python/blob/c16cab1ca22a5fac8288c1351610dfc85a4e072c/src/a2a/compat/v0_3/jsonrpc_adapter.py#L222-L247

The in-repo v0.3 client only works because it patches the missing member back in before parsing:

https://github.com/a2aproject/a2a-python/blob/c16cab1ca22a5fac8288c1351610dfc85a4e072c/src/a2a/compat/v0_3/jsonrpc_transport.py#L341-L342

A stricter v0.3 client (or a JSON-RPC library that validates the envelope) treats the reply as malformed.

Repro (DefaultRequestHandler behind create_jsonrpc_routes(..., enable_v0_3_compat=True)):

from starlette.applications import Starlette
from starlette.testclient import TestClient

from a2a.compat.v0_3 import types as types_v03
from a2a.helpers.proto_helpers import new_task_from_user_message
from a2a.server.agent_execution import AgentExecutor
from a2a.server.request_handlers import DefaultRequestHandler
from a2a.server.routes import create_jsonrpc_routes
from a2a.server.tasks import InMemoryPushNotificationConfigStore, InMemoryTaskStore, TaskUpdater
from a2a.types.a2a_pb2 import AgentCapabilities, AgentCard


class Agent(AgentExecutor):
    async def execute(self, context, event_queue):
        await event_queue.enqueue_event(new_task_from_user_message(context.message))
        await TaskUpdater(event_queue, context.task_id, context.context_id).complete()

    async def cancel(self, context, event_queue):
        pass


card = AgentCard(name='demo', capabilities=AgentCapabilities(push_notifications=True))
handler = DefaultRequestHandler(Agent(), InMemoryTaskStore(), card, push_config_store=InMemoryPushNotificationConfigStore())
client = TestClient(Starlette(routes=create_jsonrpc_routes(handler, rpc_url='/', enable_v0_3_compat=True)))


def call(method, params):
    return client.post('/', json={'jsonrpc': '2.0', 'id': 1, 'method': method, 'params': params}).json()


task_id = call('message/send', {'message': {'kind': 'message', 'messageId': 'm1', 'role': 'user', 'parts': [{'kind': 'text', 'text': 'hi'}]}})['result']['id']
call('tasks/pushNotificationConfig/set', {'taskId': task_id, 'pushNotificationConfig': {'id': 'cfg', 'url': 'https://example.com/hook'}})
body = call('tasks/pushNotificationConfig/delete', {'id': task_id, 'pushNotificationConfigId': 'cfg'})
print(body)
types_v03.DeleteTaskPushNotificationConfigResponse.model_validate(body)
print('valid')

Output on main (c16cab1):

{'id': 1, 'jsonrpc': '2.0'}
pydantic_core._pydantic_core.ValidationError: 2 validation errors for DeleteTaskPushNotificationConfigResponse
JSONRPCErrorResponse.error
  Field required [type=missing, input_value={'id': 1, 'jsonrpc': '2.0'}, input_type=dict]
DeleteTaskPushNotificationConfigSuccessResponse.result
  Field required [type=missing, input_value={'id': 1, 'jsonrpc': '2.0'}, input_type=dict]

Expected: {"id": 1, "jsonrpc": "2.0", "result": null}, which is what the v1.0 binding sends and what the v0.3 schema requires.

Actual: the result member is missing, so the response is neither a valid success nor a valid error.

I have a fix with a test and can open a PR.

Code of Conduct
  • I agree to follow this project's Code of Conduct
Vorherrschende Sprache
Python
Sterne
2.2k
Forks
540
Ø Merge
2 T. 10 Std.
Gemergte PRs (30 T.)
57

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus a2aproject/a2a-python

Alle Issues in a2aproject/a2a-python

Ähnliche Issues

Weitere Issues zu Python

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.