svelte-table: controlled expanded and pagination state resets straight after every change

Offen
  • Stimmt etwas nicht?
#6,640 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

@NickSpag arbeitet bereits daran.

Seit 22.10.2026.

  • #6641 von @NickSpag — offen

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
25/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Veraltet
Tech-Stack
typescript
Bereich
frontend

Rechercherichtung

Read the Svelte adapter’s options store in packages/svelte-table/src/reactivity.svelte.ts and the options sync effect in packages/svelte-table/src/createTable.svelte.ts, then trace how packages/table-core/src/core/row-models/createCoreRowModel.ts memoizes data and triggers auto-resets. Reproduce with the linked standalone example and check controlled expansion, pagination, and row.original identity. Done means controlled state persists across changes and unchanged caller data retains its identity.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

TanStack Table version

svelte-table 9.3.1 (and table-core 9.3.1). First seen on 9.2.4.

Framework/Library version

svelte 5.57.0

Describe the bug and the steps to reproduce it

When expanded or pagination is controlled through state and on*Change, and with a plain array (constant/$derived value/TanStack Query result) for data, row.toggleExpanded() and table.nextPage() dont do anything. The table applies the change and then resets the slice to its initial value, on every click. With data held in $state the bug doesn't show, because Svelte keeps the existing proxy.

The Svelte adapter's options store is a deep $state (reactivity.svelte.ts#L35). On each options sync, the $effect.pre in createTable (createTable.svelte.ts#L87-L102) writes a new options object that holds the caller's raw data array, and $state wraps that array in a new proxy each time. So table.options.data gets a new identity on every sync, even though data itself hasn't changed. The core row model memoizes on table.options.data and runs the auto-resets whenever it recomputes (createCoreRowModel.ts#L31-L38). Changing a controlled slice re-runs the sync, so every change undoes itself.

#6374 is this bug for pagination. It was closed with autoResetPageIndex: false as the workaround; autoResetExpanded: false works the same way for expansion. Both also turn off the reset for genuine data changes. The same proxying means row.original is a Svelte proxy, not the object the caller passed in.

The three tests in the standalone repro fail on 9.2.4, 9.2.6 and 9.3.1 every run:
https://github.com/NickSpag/svelte-table-controlled-state-repro

Steps:

  1. Render ControlledExpanded.svelte.
  2. Click "Ada: closed". It stays closed: onExpandedChange receives { "0": true }, then {} from table_resetExpanded.
  3. "same data" renders false.
Your Minimal, Reproducible Example - (Sandbox Highly Recommended)

https://stackblitz.com/github/NickSpag/svelte-table-controlled-state-repro

Screenshots or Videos (Optional)

No response

Do you intend to try to help solve this bug with your own PR?

Yes, I am also opening a PR that solves the problem along side this issue

Terms & Code of Conduct
  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Vorherrschende Sprache
TypeScript
Sterne
28.5k
Forks
3.6k
Ø Merge
18 Std. 5 Min.
Gemergte PRs (30 T.)
12

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus TanStack/table

Alle Issues in TanStack/table

Ähnliche Issues

Weitere Issues zu TypeScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.