Reject invalid framework/game combinations and offer a multi-framework bridge
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 55/100
Rechercherichtung
Start in mcp-server/tools/manifest_common.py at VALID_* and validate_inputs (around lines 21-44) to see how framework, game and language are checked independently. The templates/qbox and templates/vorp fxmanifest.lua headers state the game pinning rule that should become a FRAMEWORK_GAMES map. Run the MCP server per the issue and confirm vorp+gta5 and qbox+rdr3 are rejected while valid combinations still pass. The bridge part (snippets/lua/framework-bridge.lua) is larger design work and can be split out.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Summary
validate_inputs checks game, language and framework independently, so the scaffold and manifest tools accept combinations that cannot load, such as framework="vorp", game="gta5" or framework="qbox", game="rdr3". There is also no scaffold option for a multi-framework bridge, which is how many public resources are built.
Where
mcp-server/tools/manifest_common.py:21-44(VALID_*,validate_inputs)templates/qbox/fxmanifest.lua:2(games { 'gta5' } -- Qbox is FiveM-only),templates/vorp/fxmanifest.lua:2examples/*/server/main.lua:1-15(hand-written ESX/QB bridge, repeated per example)mcp-server/server.py:45(framework docstring)
Details
- The repo's own templates pin ESX/QBCore/Qbox/ox_core to
gta5and VORP/RSG tordr3, but this rule lives only in template comments. - The only multi-framework pattern is a hand-written
GetResourceState(...) == 'started'bridge repeated in the examples, covering ESX and QB only. The scaffold can target only one framework.
Impact
The agent can generate resources that depend on a core that does not exist for the chosen game. Authors of publicly released resources, which commonly support several frameworks, get no scaffolding help.
Suggested fix
- Add a
FRAMEWORK_GAMESmap (esx, qbcore, qbox, oxcore: gta5; vorp, rsg: rdr3; standalone: any) and return an error (or a clear warning) fromvalidate_inputsfor mismatches, includinggame="both"with a single-game framework. - Add
framework="bridge"to the scaffold, plus asnippets/lua/framework-bridge.lua, generating abridge/module withGetPlayer,AddMoney,RemoveMoneyandNotifyfor the supported frameworks, selected at runtime withGetResourceState.
Acceptance criteria
-
scaffold_resource_toolandgenerate_manifest_toolreject (or warn on)vorp+gta5andqbox+rdr3. - Valid combinations are unchanged.
- A
bridgescaffold produces a resource that loads under at least ESX, QBCore and standalone.
Getting started
- Relevant files:
mcp-server/tools/manifest_common.py,mcp-server/tools/scaffold.py,snippets/lua/ - How to run checks: there is no test suite yet; run the MCP server with
cd mcp-server && pip install -r requirements.txt && python server.py, and CI checks live in.github/workflows/validate.yml - Related docs:
skills/framework-detection/SKILL.md,skills/resource-scaffolding/SKILL.md
Filed by repo-audit/full-audit at 701824d. Severity: medium. Effort: S. audit-key: enhancement|mcp-server/tools/manifest_common.py|validate_inputs
- Vorherrschende Sprache
- Python
- Sterne
- 7
- Forks
- 4
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus TMHSDigital/CFX-Developer-Tools
-
help wanted severity: low tech-debt
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 45/100
TMHSDigital/CFX-Developer-Tools#79 ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement help wanted severity: low
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 55/100
TMHSDigital/CFX-Developer-Tools#68 ·
Maintainer antworten meist innerhalb von 1 Tag
-
help wanted severity: low tech-debt
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 35/100
TMHSDigital/CFX-Developer-Tools#66 ·
Maintainer antworten meist innerhalb von 1 Tag
-
dependencies severity: low
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 65/100
TMHSDigital/CFX-Developer-Tools#62 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement severity: medium
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 42/100
TMHSDigital/CFX-Developer-Tools#57 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in TMHSDigital/CFX-Developer-Tools
Ähnliche Issues
-
hive size:simple
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
-
A new VOLTTRON_HOME starts with agent isolation mode on (string comparison of a boolean default)Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 70/100
painted-porch/marcus#977 ·
Maintainer antworten meist innerhalb von 1 Tag
-
llm translation
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
FAIRmat-NFDI/sand#239 ·
Maintainer antworten meist innerhalb von 1 Tag