Roiling tempest and custom modifier "more maximum lightning damage" doesnt seem to apply for phys2light conversion

Offen
  • Stimmt etwas nicht?
#10,407 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 8 Tagen

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
45/100
Issue-Typ
Bug
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
lua
Bereich
backend

Rechercherichtung

Load the build code from the issue in Path of Building and compare the Divine Ire damage breakdown with and without Roiling Tempest enabled. The report says the custom modifier "more maximum lightning damage" is ignored after physical-to-lightning conversion, and the same thing happens with Hydrosphere, Divine Retribution and Storm Burst. Done means the lightning damage ranges change in the calculation as they do in-game for these spells.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

bug: calculation
Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

In game enabling roiling tempest on my 100% phy conversion divine ire, my damage ranges are updated correctly on tool tip. However on pob it doesn't change anything at all, this also applies to other phys2light conversion spells like hydrosphere, divine retribution and storm burst for example.

What is the value from the calculation in Path of Building?

no change at all.

How to reproduce the issue

No response

PoB for PoE1 build code
eNq9XF134jgSfZ75FT480wEbMDCH9BxCSCezSYcBunt3XuYotgBNC4u2ZQj961cl-ZNgImN252EOkevekkqqUlkq9-D31zU1ttgPCPOua-ZVs2Zgz2Eu8ZbXtS_zuw-92u8ffx1MEF89L25CQuHJx19_GcjfxgZ5fIWZ94T-Yf4n5l7XPjMP19J24uXaHYqC4DNa4-vazBEqawbFW0yFZrtmrBHxZsz5jvknn4Ub0VgzXpDnEp7AV8hHDsf-I6CGIWdPzBVc3A_FU478JeZf48G0_haD2RK8UzIPT5Pn6bxmoMDBnjtKOyKpxZB-GUwo2mN_xhE3AvG_69pQWAYt8T3hggnRUEhbZuuqa3VqjZOIm9AP-C1ai5-6yNkGYzcR7ly1igQnPh4vFtjhZItHPuGjFfKcVI1dhCsr-xRSTjaUYD-RN68Ku3__htxsNouE54wjejuZpbJmy7rqtoutoxAsnYdC7m-Er26osGUpfkA9LD3CcWnYhJGAeWeNJgsqHNAopFQ4nZbsFAfY3yJO8h0q5mbrF-KVtNXQx-h5odbgFLkkDJ4w93GQrvQi5BPy0IgF6Sy2T0lOsC9clecAzXcAM-ww4d1ZiGVeWRpqjoML9T2SBdaXLDWUCFC2N-eNYzzTlStNfF6HpiJm6knOWEg1JXkaw6wTzvMjK2j3igRv8Wsi1Sqke_DSnpmtzgmtWcn-Ca1bxuWe-d5wZXgZ309S9Z2u2Hpabdvu2Va30Bsmq31AHESf0CtZh2sR0ufoO04VWu0TC3C54p4IU0VYs90twt4RH58BGzHqngNbIRYU4jonXUzHEmIfd34D4QfP0XPcL54vw3Zm-z9p6QWeCn-CROOFYl1IqiRyS519WulaYi9SuNcb0CPGzuqTyOamiGO90J32pt89aVkQ1rIsCB6x7An-PKKEmQB43Eytq5M7XElDjT3sL_ezFcHULScdd2yENhrREuycRWvZO6-u1JrJQkua5BvyXb09pWyftijIBlvTPm0uJa63MrFITwXAxQcZc7M45Wf_QMJPy8GG_pqFvuaEK2GtAcT7hHrBmWI3dPQ2puS95YaK9zzdYSQo0U9KS0GHnCPn-y1zl9pGk0pKIfL9m4WbjYghsBp0CWADFJk7yaQyH2wN6WexlLU8GrZKfQWptLaCZPvX13IA0R8L7N8lBpOKa6tIJvRJBIu12ATku_kTy-wiV83ChO5OvK9pvXxJQc2XwAnbic6v4IQjKCctUp10Oyrsio-9n3tt_py4loKx54Y-eIO2jkPEMTVzshaxNAhuEUeGG-XHX5FPkMcteX4UYOQ7q0cx-9e17F93iNIXERqg9QBoAhD4Bw15yAW_PjOOA1AJrfEfgxHzFmRpIHUUI_-YYQ5w2bukxSBu3CgH6uCVcDHsG548gMIeXu-j4x8vXL9g_7rWjbONQkD2OCdGdTQw8alUjGmdUDRbiVg7gxAapADzPSXgcYdaen37HVh-U0mRltV-T2MSSs7AZkNjYsYTJlknp2Jw9oN97Er7jFgowgSmi4ydOrrdLqM_j5zAu0sykycm0mFi4ZeYyYAsCX1eyEAiYNJjtReAaNHtmATAjlYKECc2sbxt9nv9dzBJQpcMo2m2dXp25qIqB4M4hm_FKsg79Kk1lK7EMei8FxGN7cSauKPisf5syaP0jKO2i-U3SRr6tqftpk5YOFzpLS1Pyw9NreIpXovN2b3ZDynd6482m2rpuJujYrhIkLmP6Jwsxb4Krq4fc6MkmVE6RV52QXQTtaMw4Gwt8guyEKOVCa7BCacYDn0WSNgBbmXgbd-N7jok7hcJbhxBy-2nkew_ci9Tf8HPuY_xV4J3xk_G1v-BA1-zfdXvdrt2vEPOuA8bIzx_VPczPfFoxXawP98SkR6JBMDBQXzzAoL_FmmY2etcCV_sqBOmwew7oTQQ-6scwycck3nMXyenTLVo_5TC0faZgfwZIkr4HhIFI2A-NAU3e5EzxbpzjXfwCnlwrC37LZJyJTffb6Dfw8dH9eQRL5GzB4Lr2gLRILoKinuT27plo0HRCwzicEoM4jk0dPGDFyWAYpyEqlutYTrCEaJOIMd48ACOzdW0DkRvjB-ZcStFnyh7QdSM1WUbrbjRgbUp2Zd4_eDCuyZHrsiOGg9cDLEB42ykxoj33DlLdpQ3w9qqrAjIIuBRVABjeE8I3AJ8KX2FNDgzMgLRbWB8RhvZQnJPkM9T4yVNYLb_qbFAkfh1S7ZiRc3xWiwffspISvDBxxmbZNpSE6hGQ7a-M27Zyf_DIGdceKa8uzy5DDJS6bRnGtMxylYjaj4c5EDpVcEqdjgZq1TggJ-yk6dCjwoeIBbHjjDA6r7hG0Yb5slm8ESpJxIsFMr7O2UiAHBlt2YtiuoKYQhN8Gjy8mX6KKJB4xRkKPYyzEsA7jFdlwJEnbJKQG6YuzfiTEobJZbXFpLBEmoYLyM_FYGglHElwCoLaJU3rmnMdmhjDF_2QSAilypVKNXVk0TWpYguNrT2pYg6lyKyzyG6xIRdYq4uMU2XmKFLTE71ebEu5U3WpbzJupQ3WZfyJutS3mRdypusi0zYJebqEtN0iRm6xORUmBeVKVSZleMMVmWGVmWGdmWGTmUG-7yMqsqEnKCxLkPTugxN-zI0ncvQ2KWz2CqTdJzBqszQqszQrszQqcxgl31BqOYvRwisqgStqgTtqgSdqgSlZgHTSrvIMbxVEd-qiG9XxHcq4svY_46i4HspiyuEVRrRKo04-z3w3ES1TPzx0aJk5JaIsmuztNGOLZ5BIzp_kqdc8mxLHnKt4cTUwK_y4BT5cMinzqLlMbpsMVwccOLJ0u7r2pDSmjFbsd3Q3cI9zJwxmhxgG2izwZ6b45Anp-oEzNuEPL5iIYHz90u4WMAnEjUj4L787mN8dzcezR--jqNeZyHywO9vdYfx5tplMMOyEshwGKVoE-CkE_JcLTrjo0JIKAtfAiV9XYPbCPnwFnNEaKDFdp_eZWe5JE_6TIfpG_Idn8CpVpZo_Ip9YfFl8lSHaoIcfsgjZncnL4qhPEiPRn7p8GZUakhQwAaFD3omV2UFWSpVEzVCAZcldjosUDeQJ4EWvaGIxY3owRxFbdprBi5t4Pw3OGIUDhc6G-yQBXGUjObiiYsncrZxnNBHzl6LQ35lkserJq2FIr8ayaOjNi2rym9VDqyq2rTWF3bQPo9WTTrgpEQzT5A0Mw8-mNJhGlM8JBQqrA5m9jPz5GIX7pcI6BA-iYCmqrcOCJ-hViN-osMkvMQnLyE_jAqZdi1byarxnJmgRWsssiw6C5UtWnbNFQrnglH2iWZsPKCQLTrQ-J49C1ZtmlMQ3U3kzK_atIwQF3zkxh81ajmJDLfDLSPu20hx-LAyoby4v0C_oHK1Os1hKasWo0x8DvwlaiuER3fnBegvnMCdZzUS8LhqDOB41RjmxHN46GMtgumbpGZ6MpVJkUl1ZW6vjhrPxSeVmGczqHrRs-GyCk07_t_ihbwhPrIBJI-qcd2JNB3SDZmMV-Sa8dC7FeY9TZUa6J0RagQkfS6185Yymgoq0UdVb-OlelCdSOQF97oJaCFTUuZ9jxGF73gZrUZ4-FWZxhQUcsGXKuEGeW7M9lwm7S-2HuOBIJWFzbfwRUxQqZey8jDDM2jEL5qyyiwu7ZK1IFFVNPxhBLL2Avn7Yfo1PrxDyxIMh4YBh6q_YHUHlWLpJ_0WVE3Bs32UykEZFspTwGu4eJsVjzpW36637WbfqnfMvtWq9_rtXr3T67Va9Xav2-3VWz2za9dbrU67Uzd7TWgXP-16xzY74ne3aVt1q2t3-vV23-6Y9XbL7tZbXbtr1s1-pyn-b9q9XvTPGkTKOVTXpf8GgdWPikm-TB9Vac-K803wW6Ox2-2uNoiv2AK_EoqvHLZubASPMNgH-Zb9AagaQ_HfzXI4HE9nOz78-a_m_rG5ZT--Pjw8_TH1Pr1-_8z_4v2_glHv_uf4zw_zP5o7_ogEYHh9rapsYs0DdSwVRIcXsKB8IiwVHU3AxMgphJn7-OugcfiPPvwXNMUq6w==
Screenshots

No response

Vorherrschende Sprache
Lua
Sterne
5.5k
Forks
2.4k
Ø Merge
6 T. 14 Std.
Gemergte PRs (30 T.)
13

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus PathOfBuildingCommunity/PathOfBuilding

Alle Issues in PathOfBuildingCommunity/PathOfBuilding

Ähnliche Issues

Weitere Issues zu Lua

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.