Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

getFoldersMatching adds root "/" even when it is not an inclusion

Offen
  • Stimmt etwas nicht?
#788 2 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@jgclark arbeitet bereits daran.

Seit 17.10.2026.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Beschreibung

Summary

getFoldersMatching() in helpers/folders.js adds the root folder / to its result whenever / is not an exclusion, even when the caller passed a non-empty inclusion list that does not contain /.

That is why a Dashboard perspective that includes only CCC and excludes Notes still lists / in perspectiveScopeUnion.json (seen via Projects + Reviews test: log perspective scope union). Root notes (a filename with no /) then match that scope.

resolvePerspectiveFolders() in jgclark.Dashboard/src/perspectiveScopeUnion.js calls getFoldersMatching() whenever a perspective has a non-empty include list, so it inherits this.

Proposed change

When the inclusion list is non-empty, include / only if / is one of the inclusions. Keep the existing special case where the only inclusion is / (return ['/'], unless / is excluded).

When the inclusion list is empty, keep today's meaning: every folder, including /, unless / is excluded. Folder pickers rely on that.

The tests in helpers/__tests__/folders.test.js currently expect / on a CCC inclusion (the case titled "does not include root folder" asserts toContain('/')). Those would need to change with this.

@dwertheimer -- does this match how you want getFoldersMatching() to treat root? In particular, should an empty inclusion list still return /?

Plugins and commands this would change

Only callers that pass a non-empty inclusion list that does not contain /.

Dashboard (jgclark.Dashboard)

Live folder filter (getCurrentlyAllowedFolders, filterParasByRelevantFolders, tag sections):

  • Show Dashboard
  • Show Demo Dashboard
  • Explain selected item filters
  • Generate Diagnostics file
  • test Perspective Filter

perspectiveScopeUnion.json, via resolvePerspectiveFolders():

  • showPerspective
  • Add new Perspective
  • Update current Perspective
  • Delete Perspective
  • Delete all Perspective Settings
  • onUpdateOrInstall
Projects + Reviews (jgclark.Reviews)

getFilteredFolderList() calls getFoldersMatching() when foldersToInclude is set (from the active perspective when Use Perspectives is on). The union file is also read when FFlag_UseCacheOfAllPerspectives is on, and always by the two test commands:

  • project lists
  • start reviews
  • next project review
  • finish project review
  • finish project review and start next
  • skip project review
  • weeklyProjectsProgress
  • heatmaps for weekly Projects Progress
  • migrate all projects
  • Projects: update plugin settings
  • test: log perspective scope union
  • test: force rebuild allProjectsList from union
Folder pickers that pass a start folder

chooseFolder() in helpers/userInput.js passes [startFolder] as the inclusion list when a start folder is given. Those pickers would stop offering / unless the start folder is /:

  • Templating (np.Templating), when a template uses <select:SomeFolder>
  • shared.AI, the "Move to which directory?" prompt when researchDirectory is set

chooseFolder() with no start folder, and the getFolders handlers in np.Shared, dwertheimer.Forms, and dwertheimer.ReactSkeleton, pass an empty inclusion list. Under the proposal above they would still include /.

Vorherrschende Sprache
JavaScript
Sterne
204
Forks
81
Keine gemergten PRs in 30 T.

Entwicklungsumgebung

Dieses Projekt bietet weder Dev-Container noch Dockerfile noch Beitragsleitfaden – die Einrichtung liegt bei Ihnen. Beginnen Sie mit der README; die allgemeinen Schritte stehen in unserem Leitfaden für den ersten Beitrag.

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus NotePlan/plugins

Alle Issues in NotePlan/plugins

Ähnliche Issues

Weitere Issues zu JavaScript

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.