Voice input fails in browser address bars due to incorrect password field detection (v4.2.9, follow-up to #516)
Maintainer antworten meist innerhalb von 1 Tag
Dieses Issue hat noch niemand übernommen.
Bewertung
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Anfängerfreundlichkeit
- 76/100
Rechercherichtung
Lies VoiceInputManager.kt im Bereich von isBlockedEditor() und vergleiche die Passwortprüfungen mit den klassenbewussten Hilfsfunktionen in InputTypeUtils.kt. Prüfe die vorhandenen Tests für die Spracheingabe, sofern es welche gibt, und verifiziere, dass URL-Felder in der Adressleiste nicht mehr abgelehnt werden, während Passwortfelder weiterhin blockiert bleiben. Fertig ist es, wenn die Spracheingabe in Adressleisten des Browsers startet und Passwortfelder weiterhin ablehnt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Describe the bug
Voice dictation still fails in browser address bars after the fix for #516, included in LeanType v4.2.9.
Tested browsers: Firefox, Chrome, and Brave. The issue occurs in all three.
The microphone button appears in the address bar, but tapping it shows:
Voice input not available or permission missing
Voice dictation works correctly in ordinary text fields, including input fields within webpages.
Relationship to #516
Issue #516 was closed as completed via commit 3373e94.
That commit removed this condition from InputAttributes.kt:
- hasNoMicrophoneKeyOption() ||
This stops the app's NO_MICROPHONE flag from hiding the microphone button in browser address bars. However, it addresses button visibility, not the separate activation-time check. The button is now visible but voice recording still fails.
Root cause identified in source code
LeanType uses two inconsistent password-field checks.
1. Microphone visibility — class-aware
InputTypeUtils.isPasswordInputType() checks both the input class and variation:
val maskedInputType = inputType and
(InputType.TYPE_MASK_CLASS or InputType.TYPE_MASK_VARIATION)
Source: InputTypeUtils.kt, lines 56–65
2. Microphone activation — checks variation only
VoiceInputManager.isBlockedEditor() uses:
val variation = info.inputType and InputType.TYPE_MASK_VARIATION
return variation == InputType.TYPE_TEXT_VARIATION_PASSWORD ||
variation == InputType.TYPE_TEXT_VARIATION_WEB_PASSWORD ||
variation == InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD ||
variation == InputType.TYPE_NUMBER_VARIATION_PASSWORD
Source: VoiceInputManager.kt, lines 1071–1079
Android assigns the same numeric variation (0x10) to these two types:
TYPE_TEXT_VARIATION_URI— URL fields (text class)TYPE_NUMBER_VARIATION_PASSWORD— numeric password fields (number class)
Because isBlockedEditor() ignores TYPE_MASK_CLASS, a URL field can be incorrectly identified as a numeric password field. This explains the discrepancy between button visibility and activation.
Log evidence
The LeanType diagnostic log repeatedly shows the following immediately after tapping the microphone:
SuggestionStripView: click toolbar key VOICE
VoiceInputManager: canStartVoice: Blocked editor (password)
Other regular text fields successfully initiate recording and transcription. The logs establish that the password-field rejection is occurring; the source code indicates the cause of the misclassification.
To Reproduce
- Install LeanType v4.2.9 (standard flavor).
- Open Firefox, Chrome, or Brave.
- Focus the browser address bar.
- Tap LeanType's visible microphone button.
Actual behavior: Recording does not start. Instead, the keyboard reports Voice input not available or permission missing.
Expected behavior
Voice dictation should activate in browser address bars and insert recognized text as it does in regular text fields.
Suggested fix
Make VoiceInputManager.isBlockedEditor() check both input class and variation, ideally by reusing the existing class-aware utilities:
fun isBlockedEditor(info: EditorInfo?): Boolean {
if (info == null) return false
return InputTypeUtils.isPasswordInputType(info.inputType) ||
InputTypeUtils.isVisiblePasswordInputType(info.inputType)
}
This avoids duplicating password-detection logic and prevents collisions between URL fields and numeric password fields.
Screenshots
A screenshot showing the error message in the address bar is available. LeanType diagnostic logs are also available, showing repeated Blocked editor (password) warnings.
App version & Flavor
- Version: 4.2.9 (4209)
- Flavor: Standard
- Voice provider: Online
Device Info
- Model: Nothing Phone (2)
- OS version: Android 16 (SDK 36)
Related: #516 — Voice dictation does not work in browser URL bars. Its fix addressed microphone-button visibility, but the separate activation-time password-field detection remains defective. Please track this as a follow-up to #516.
- Vorherrschende Sprache
- Kotlin
- Sterne
- 1k
- Forks
- 59
- Ø Merge
- 13 Std. 11 Min.
- Gemergte PRs (30 T.)
- 47
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Hat eine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus LeanBitLab/LeanType
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 65/100
LeanBitLab/LeanType#423 · 1 Kommentar ·
Maintainer antworten meist innerhalb von 1 Tag
-
Crush ReportOffen
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 20/100
LeanBitLab/LeanType#715 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Text Expander/cursor-handling bugEvtl. vergeben @LeanBitLab hat das vor 2 Tagen übernommen. Offenbug
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 62/100
LeanBitLab/LeanType#703 · 1 Kommentar · 1 zugewiesene Person ·
Maintainer antworten meist innerhalb von 1 Tag
-
enhancement
Schwierigkeit 3/5 1-2 Tage Anfängerfreundlichkeit 45/100
LeanBitLab/LeanType#699 ·
Maintainer antworten meist innerhalb von 1 Tag
-
support minicpmOffenenhancement
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 30/100
LeanBitLab/LeanType#698 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in LeanBitLab/LeanType
Ähnliche Issues
-
bug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
leboncoin/spark-android#2342 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Bug Domain changed
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
keiyoushi/extensions-source#20257 · 1 Kommentar · 1 Reaktion ·
Maintainer antworten meist innerhalb von 1 Tag
-
bug
Schwierigkeit 1/5 Unter einer Stunde Anfängerfreundlichkeit 85/100
Maintainer antworten meist innerhalb von 1 Tag
-
feature
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 62/100
user-grinch/RivoPhoneApp#302 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
Maintainer antworten meist innerhalb von 1 Tag