driver: suggest the closest triple for an unknown --target=

Offen
  • Stimmt etwas nicht?
#188 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
85/100
Issue-Typ
Feature
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
c
Bereich
compilers

Rechercherichtung

Read src/driver/main.c around the unknown-target error and src/sema/sema.c around edit_distance() to understand the existing suggestion logic. Share that helper for the driver, then update tests/golden/triple.sh to cover a one-letter typo and a distant target such as banana. Done when the typo suggests the closest built triple, the distant target gets no suggestion, and the listed checks pass.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

enhancement good first issue

Context. A mistyped triple gets the whole list of targets EmbCC knows, with no hint about which one was meant:

$ ./embcc --target=thumbv7m-none-eab -c t.c
embcc: error: unknown target 'thumbv7m-none-eab'
embcc: the targets it emits for are:
embcc:   x86_64-elf
...

clang and GCC users expect did you mean 'thumbv7m-none-eabi'?.

Where.

  • src/driver/main.c, around line 7091: the unknown target error, which walks target_triple_count() / target_triple_name().
  • src/sema/sema.c, line 2108: edit_distance(), a bounded Levenshtein distance that already powers "did you mean" for undeclared names. It is static there. Move it somewhere the driver can share (for example src/driver/util.c and util.h), rather than copying it.
  • Tests: tests/golden/triple.sh already checks the unknown-target error.

Steps.

  1. Make edit_distance shareable, and keep sema's use of it unchanged.
  2. In the unknown-target branch, find the built triple (target_triple_built(t)) closest to what was typed. If it is within a few edits (sema uses max(2, len / 3)), print embcc: note: did you mean 'X'? before the list.
  3. Add cases to tests/golden/triple.sh: a one-letter typo gets the suggestion, and something far from every triple (--target=banana) gets none.

Done when --target=thumbv7m-none-eab suggests thumbv7m-none-eabi, a nonsense triple suggests nothing, the test covers both, and make check and sh tests/golden/triple.sh pass.

Before you start: the contributor's guide has the rules. A new test counts only after it has failed against the code before your change, and a commit subject reads area: summary. Questions are welcome in the comments or in Discussions.

Vorherrschende Sprache
C
Sterne
1
Forks
2
Ø Merge
20 Std. 55 Min.
Gemergte PRs (30 T.)
73

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus EmbLinkOs/EmbCC

Alle Issues in EmbLinkOs/EmbCC

Ähnliche Issues

Weitere Issues zu C

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.