Hacktoberfest 2026: die Issues, die Maintainer für den Oktober markiert haben – offen und einsteigerfreundlich. Hacktoberfest-Issues durchsuchen

Replica add-task silently drops due and wait dates (DateTime.toString is not RFC3339)

Geschlossen
#662 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

@NaitikVerma6776 arbeitet bereits daran.

Seit 03.10.2026.

  • #663 von @NaitikVerma6776 — ohne Merge geschlossen

Bewertung

Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Anfängerfreundlichkeit
78/100
Issue-Typ
Bug
Klarheit
Klar beschrieben
Aktivitätsstatus
Aktiv
Tech-Stack
dart, flutter, rust

Rechercherichtung

Start with AddTaskBottomSheet.onSaveButtonClickedForReplica in lib/app/modules/home/views/add_task_bottom_sheet_new.dart and Replica.addTaskToReplica in lib/app/v3/champion/replica.dart, then inspect parse_datetime in rust/src/api.rs. Run the relevant Dart and Rust tests available in the repository; done means replica-created tasks retain the selected due and wait timestamps in RFC3339-compatible form.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Description

On the TaskChampion / replica path, creating a task with a due or wait date from the Add Task sheet reports success, but the date is not stored.

The add sheet puts a Dart DateTime into the replica map. Replica.addTaskToReplica then calls .toString() on that value. Dart’s DateTime.toString() uses a space (2026-10-03 12:00:00.000Z). The Rust FFI parse_datetime only accepts RFC3339 (2026-10-03T12:00:00.000Z). Parse failure becomes None, and set_due / set_wait clear the field. The write still succeeds, so the UI shows “task added”.

The edit path already formats with toIso8601String() (which includes T), so dates set on the detail screen survive. Only create is wrong.

This is source-confirmed on main (90700d4). I could not run the Flutter app in this environment (no Flutter SDK).

Steps to reproduce

  1. Enable TaskChampion replica mode (settings_taskr_repl).
  2. Open Add Task.
  3. Enter a description and pick a Due (and/or Wait) date/time.
  4. Save. Confirm the success snackbar.
  5. Open the new task (or list it after refresh).

Expected behavior

The due/wait timestamp chosen in the add sheet is stored on the replica task, same as when the same date is set later on the edit screen.

Actual behavior

The task is created without due / wait. The add sheet still reports success.

Technical analysis

Create path

AddTaskBottomSheet.onSaveButtonClickedForReplica (lib/app/modules/home/views/add_task_bottom_sheet_new.dart) passes:

due: getDueDate(homeController.selectedDates)?.toUtc(),
wait: getWaitDate(homeController.selectedDates)?.toUtc(),

Replica.addTaskToReplica (lib/app/v3/champion/replica.dart) stringifies every attribute with:

map[attr] = newTask[attr].toString();

For a UTC DateTime that is 2026-10-03 12:00:00.000Z (space, not T).

FFI

parse_datetime in rust/src/api.rs:

fn parse_datetime(input: &str) -> Option<DateTime<Utc>> {
    if input.trim().is_empty() {
        return None;
    }
    input.parse::<DateTime<Utc>>().ok()
}

Empty or unparsable input → None. add_task then does t.set_due(parse_datetime(&value), …) with no error if parse fails. Rust unit fixtures correctly use 2026-09-01T09:00:00Z(withT`), so they never catch this.

Edit path (works)

TaskcDetailsController.saveTask converts with parsed.toUtc().toIso8601String() before modifyTaskInReplica. That string still goes through .toString(), but it is already RFC3339.

Impact

Users on the replica / TaskChampion path (the GSoC v3 default) lose due and wait dates at creation. Overdue highlighting, wait filtering, and sync to other Taskwarrior clients all miss those dates until the user re-enters them on the detail screen. The success snackbar hides the failure.

Possible fix

  • In addTaskToReplica (and anywhere else a DateTime is put on the map), send toUtc().toIso8601String() instead of toString().
  • Optionally make parse_datetime reject unparsable non-empty strings instead of treating them as “no date”, so a bad format cannot succeed silently.
  • Add a regression: add a replica task with a due string in Dart DateTime.toString() form and assert it is stored (or that the write is refused).

Environment

  • Repository: CCExtractor/taskwarrior-flutter
  • Branch: main (90700d4f08a58bcaf7e5804352a7bd565ed7ddd8)
  • App version in pubspec: 3.0.0+3
  • Dart SDK constraint: >=3.0.5 <4.0.0
  • TaskChampion FFI: rust/src/api.rs (taskchampion 2.0.3)
  • Flutter app not run locally (SDK not on PATH)
Vorherrschende Sprache
Dart
Sterne
245
Forks
183
Ø Merge
16 Std. 19 Min.
Gemergte PRs (30 T.)
4

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus CCExtractor/taskwarrior-flutter

Alle Issues in CCExtractor/taskwarrior-flutter

Ähnliche Issues

Weitere Issues zu Dart

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.