BudgetOutcome has no consumer: the object that names which limit fired is never read outside Core/Budgets

Offen
  • Stimmt etwas nicht?
#1,253 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Maintainer antworten meist innerhalb von 1 Tag

Dieses Issue hat noch niemand übernommen.

Bewertung

Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Anfängerfreundlichkeit
48/100
Issue-Typ
Feature
Klarheit
Größtenteils klar
Aktivitätsstatus
Aktiv
Tech-Stack
csharp
Bereich
api, backend

Rechercherichtung

Beginne mit Core/Budgets/BudgetOutcome.cs und dem bestehenden Budget-Ablauf über WorkBudget.cs, BudgetLedger.cs und BudgetRecording.cs und verfolge dann die ressourcenbedingten Ausstiege in Solve. Wähle den im Issue beschriebenen Solve-Verbraucherpfad und führe einen bewusst unterbudgetierten Aufruf aus. Erledigt ist die Aufgabe, wenn der Aufrufer erkennen kann, welches Subsystem oder Limit die Suche angehalten hat, und ein Test diesen Bericht bewahrt.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Beschreibung

Measured on 2dbeedf7.

BudgetOutcome (#1035) exists to name where a budget was exhausted and why. Grepping the kernel for it finds four files:

Core/Budgets/WorkBudget.cs
Core/Budgets/BudgetLedger.cs
Core/Budgets/BudgetOutcome.cs
Core/Budgets/BudgetRecording.cs

All four are the budget layer itself. It has no consumer. The object that says which limit fired is built, tested and read by nothing.

WorkBudget itself does slightly better, reaching four call sites outside its folder:

Core/Transformations/Saturation.cs
Core/Transformations/Transformation.Catalogue.cs
Functions/Simplification/Patterns/Patterns.ExpandFactorize.cs
Functions/Algebra/Groebner/Buchberger.cs
Functions/Continuous/Solvers/EquationSolver.cs
Convenience/MathS.cs

so a budget can be spent in saturation, expansion, Gröbner and the solver — and when it runs out, the outcome that would say so is not the thing that reaches the caller.

Why re-open this rather than read it off #1036

#1036 ("giving up on a resource is spelled the same as a mathematical negative") was closed as completed on 2026-08-24, and #896 with it. Its step 1 landed in #1046 and is real: Solve's two resource-driven exits answer with the equation as a set builder instead of { }, so an empty set means an established emptiness again.

But #1036 was about one chokepoint, and the survey behind it found roughly seventy sites that give up on a resource, of which one threw and one recorded which limit fired. Closing the issue closed the Solve boundary, not the class. This is filed as its own thing because the remaining work is not "finish #1036" — it is that the mechanism to do it exists and is unused, which is a different and much cheaper starting position than the survey described.

What it costs a caller today

A caller who hits a budget gets the shape of a mathematical answer with none of the provenance: which subsystem stopped, which limit it was, how much had been spent. WorkBudget carries an inherited ledger precisely so that a nested search can attribute its spend to the caller that granted it, and none of that reaches an API.

This is also #746 tier 4's prerequisite. A strategy engine picks between alternatives on the evidence of what the last one did; "it did not work" and "it ran out of room after 40,000 steps in Buchberger" select different next moves, and only the second is actionable.

Smallest first step, for discussion

Pick one consumer and take it end to end rather than sweeping seventy sites:

  • Solve is the obvious one — it already distinguishes the two exits since #1046, so it has the branch and only lacks the payload.
  • Surface the outcome somewhere a caller can read it without changing the return type of anything (a property on the result, or an out-parameter overload) — the return types are the reason this stalls, and it should not be a breaking change to find out why a search stopped.
  • Then a test asserting a deliberately under-budgeted call reports the subsystem by name, which is what stops the field going stale again.

The four sites where exhaustion is currently rendered as a mathematical claim, named in #1036's table, are the ones worth checking first — those are wrong answers rather than missing metadata.

Part of #746, tier 4.

Vorherrschende Sprache
C#
Sterne
831
Forks
79
Ø Merge
1 Std. 12 Min.
Gemergte PRs (30 T.)
518

Entwicklungsumgebung

Erste Schritte

  1. Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
  3. Forken Sie das Repository und arbeiten Sie in einem Branch.
  4. Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.

Mehr aus ASC-Community/AngouriMath

Alle Issues in ASC-Community/AngouriMath

Ähnliche Issues

Weitere Issues zu C#

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.