ci: sync uv.lock version when changesets bumps pyproject.toml

Open Beginner friendly
  • Is something wrong?
#668 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 2 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python, shell, yaml
Domain
build-system, ci-cd, release

Research direction

The version bump lives in the sed block of .github/workflows/changesets.yml, which rewrites pyproject.toml and nothing else. Check whether a make version-bump target exists, since the issue says it may need the same change. Add a step after the bump that refreshes uv.lock (for example uv lock --offline through astral-sh/setup-uv). Done when uv.lock records the new kiji-proxy version and uv sync leaves the working tree clean.

Written by the indexing model from the issue text.

Description

Problem

In .github/workflows/changesets.yml, the release PR workflow bumps version in pyproject.toml via sed, but does not update uv.lock:

# Sync pyproject.toml version
if [ -f "pyproject.toml" ]; then
  sed -i "s/^version = \"[0-9.]*\"/version = \"${NEW_VERSION}\"/" pyproject.toml
  echo "Synced pyproject.toml to $NEW_VERSION"
fi

As a result, uv.lock on main still records an older version (1.6.3) for the editable kiji-proxy package while pyproject.toml is at 1.6.8. Running uv run or uv sync locally then dirties the working tree with a modified uv.lock:

 [[package]]
 name = "kiji-proxy"
-version = "1.6.3"
+version = "1.6.8"
 source = { editable = "." }

Proposed Fix

Update uv.lock alongside pyproject.toml in .github/workflows/changesets.yml (and local make version-bump if applicable), e.g. by running uv lock --offline (via astral-sh/setup-uv) after bumping pyproject.toml.

Dominant language
Go
Stars
445
Forks
52
Avg merge
1d 8h
Merged PRs (30d)
21

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dataiku/kiji-proxy

All issues in dataiku/kiji-proxy

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.