fix(pii): email and URL generators use non-reserved, registrable domains
Maintainers usually reply within 4 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Start with the domain lists in EmailGenerator and UrlGenerator in pii_generators.go, which combine reserved-looking labels with public TLDs. Narrow the output to example.com, example.org, example.net, or names under the reserved TLDs such as .test, .invalid and .example. Done when a new generator test asserts that every produced domain uses one of those, and the existing PII detection tests still pass.
Written by the indexing model from the issue text.
Description
Summary
The email and URL generators claim to use only "RFC 2606 / RFC 6761 reserved domains", but most of the domains they produce are ordinary, registrable or live domains. If a downstream tool or agent acts on a dummy (sends mail, fetches a URL), it contacts a real third party.
Code
EmailGenerator(pii_generators.go):example.com,example.organdexample.netare reserved, buttest.com,test.org,test.net,invalid.comandinvalid.orgare not.test.comis a live site.UrlGenerator: combinesexample/test/invalid/localhostwith TLDscom, org, net, edu, gov, info, biz, co, io, dev. Apart fromexample.{com,org,net}, combinations such aswww.test.io,www.localhost.devorwww.invalid.coare regular domains. RFC 2606/6761 reserve the TLDs.test,.invalid,.exampleand.localhost, not second-level labels under public TLDs.
Suggested fix
Use only example.com, example.org, example.net, or names under the reserved TLDs (e.g. mail.test, acme.example, foo.invalid). Add a generator test that asserts every produced domain ends in one of those. Check that the dummies still look realistic enough for the PII detector and the LLM.
- Dominant language
- Go
- Stars
- 438
- Forks
- 51
- Avg merge
- 3d 2h
- Merged PRs (30d)
- 4
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dataiku/kiji-proxy
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
dataiku/kiji-proxy#635 ·
Maintainers usually reply within 4 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
dataiku/kiji-proxy#626 ·
Maintainers usually reply within 4 days
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
dataiku/kiji-proxy#596 · 1 comment ·
Maintainers usually reply within 4 days
-
internationalization
Difficulty 2/5 1-2 days Newbie friendliness 68/100
dataiku/kiji-proxy#575 ·
Maintainers usually reply within 4 days
-
Add Go package-level doc comments to src/backend/providers/May be free again @min-ok claimed this 21 days ago, and no pull request is open. Opengood first issue
Difficulty 2/5 Under an hour Newbie friendliness 84/100
dataiku/kiji-proxy#427 · 1 comment ·
Maintainers usually reply within 4 days
All issues in dataiku/kiji-proxy
Similar issues
-
[Bug]: ap gateway image build cannot find local policies on WindowsPossibly taken @Jayzilva claimed this today. OpenAspect/Configuration Severity/Major
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
wso2/api-platform#3912 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
keyxmakerx/Chronicle#1721 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Gentleman-Programming/gentle-ai#5720 ·
Maintainers usually reply within 1 day
-
compress: block buffers get re-zeroed on every call, and the zeroing is immediately overwrittenOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ClickHouse/ch-go#1218 ·
Maintainers usually reply within 13 days