REVIEW ships without its review-daily/weekly/monthly workflows, so /review waits forever

Open
#2,766 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 5 days

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
bun, typescript, yaml
Domain
backend, tooling

Research direction

Read PULSE/modules/review.ts, REVIEW/Health.ts, and the USER workflow template tree, starting with statusline-refresh.workflow.yaml to see how shipped workflows are defined. Check how the installer and /review page handle missing workflow schedules. Done means fresh installs have working review schedules and the empty state explains when no weekly review is scheduled; the issue also identifies related learning jobs whose setup may need investigation.

Written by the indexing model from the issue text.

Description

What happens

A fresh install ships LIFEOS/REVIEW/ and the Pulse /review page, but nothing schedules the reviews. On a new install the page reads "Nothing is waiting on you. New decisions appear here after the weekly review." indefinitely, although no weekly review will ever run.

Evidence (v8.761.0, also main at f6ab5e02)

  • PULSE/modules/review.ts nextRuns() reads USER/WORKFLOWS/review-{daily,weekly,monthly}.workflow.yaml, and REVIEW/Health.ts LEARNING_JOBS expects workflows review-daily, review-weekly, review-monthly.
  • The release's USER/WORKFLOWS/ holds only statusline-refresh.workflow.yaml.
  • No Setup.md, installer step (InstallAll.ts, Doctor.ts, ScaffoldUser.ts), Services.ts entry or doc tells the user to create them. REVIEW/README.md lists the commands but not who runs them.
  • The empty-state line in Observability/src/app/review/page.tsx falls back to "after the weekly review" exactly when the workflow is missing, so the gap looks like a quiet week.
  • The same holds for the other LEARNING_JOBS (errata-daily, errata-weekly, errata-misses-daily, errata-impact-weekly, ideal-reconcile, ideal-recommend); ErrataSystem.md describes errata-daily as a step of delta-daily, which is not shipped either.

Suggested fix

Ship the three review-* definitions in the USER template tree (like statusline-refresh), or a REVIEW Setup section with them, and have the empty state say "No weekly review is scheduled" when next_runs.weekly is null.

What we did locally: three command workflows running bun LIFEOS/REVIEW/Review.ts <cadence> --json on schedule triggers (daily 06:45, weekly Sunday 08:00, monthly day 1 08:30), which the dispatcher fires and /review now reports as the next run.

Dominant language
TypeScript
Stars
19.9k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from danielmiessler/LifeOS

All issues in danielmiessler/LifeOS

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.