REVIEW ships without its review-daily/weekly/monthly workflows, so /review waits forever

Aperta
#2,766 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 5 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
bun, typescript, yaml
Ambito
backend, tooling

Direzione di ricerca

Read PULSE/modules/review.ts, REVIEW/Health.ts, and the USER workflow template tree, starting with statusline-refresh.workflow.yaml to see how shipped workflows are defined. Check how the installer and /review page handle missing workflow schedules. Done means fresh installs have working review schedules and the empty state explains when no weekly review is scheduled; the issue also identifies related learning jobs whose setup may need investigation.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

What happens

A fresh install ships LIFEOS/REVIEW/ and the Pulse /review page, but nothing schedules the reviews. On a new install the page reads "Nothing is waiting on you. New decisions appear here after the weekly review." indefinitely, although no weekly review will ever run.

Evidence (v8.761.0, also main at f6ab5e02)

  • PULSE/modules/review.ts nextRuns() reads USER/WORKFLOWS/review-{daily,weekly,monthly}.workflow.yaml, and REVIEW/Health.ts LEARNING_JOBS expects workflows review-daily, review-weekly, review-monthly.
  • The release's USER/WORKFLOWS/ holds only statusline-refresh.workflow.yaml.
  • No Setup.md, installer step (InstallAll.ts, Doctor.ts, ScaffoldUser.ts), Services.ts entry or doc tells the user to create them. REVIEW/README.md lists the commands but not who runs them.
  • The empty-state line in Observability/src/app/review/page.tsx falls back to "after the weekly review" exactly when the workflow is missing, so the gap looks like a quiet week.
  • The same holds for the other LEARNING_JOBS (errata-daily, errata-weekly, errata-misses-daily, errata-impact-weekly, ideal-reconcile, ideal-recommend); ErrataSystem.md describes errata-daily as a step of delta-daily, which is not shipped either.

Suggested fix

Ship the three review-* definitions in the USER template tree (like statusline-refresh), or a REVIEW Setup section with them, and have the empty state say "No weekly review is scheduled" when next_runs.weekly is null.

What we did locally: three command workflows running bun LIFEOS/REVIEW/Review.ts <cadence> --json on schedule triggers (daily 06:45, weekly Sunday 08:00, monthly day 1 08:30), which the dispatcher fires and /review now reports as the next run.

Lingua principale
TypeScript
Stelle
19.9k
Fork
2.5k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di danielmiessler/LifeOS

Tutte le issue di danielmiessler/LifeOS

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.