[低] 诊断包与更新器各自定义更新目录路径

Open Beginner friendly
#40 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
desktop-dev

Research direction

Read windows/birdlock/core/diagnostics.py around line 49 and windows/birdlock/app/updates.py around lines 104-105; both build the same LOCALAPPDATA/BirdLock/updates path inline. Put one Qt-free helper (a plain function taking no widgets, so it can live in a core module next to diagnostics) and have both call sites import it. Done looks like a single definition of that path, with neither module keeping its own copy, and the updater still resolving the same directory as before.

Written by the indexing model from the issue text.

Description

位置:windows/birdlock/core/diagnostics.py:49;windows/birdlock/app/updates.py:104-105

现象:两处都写 Path(os.environ.get('LOCALAPPDATA', Path.home())) / 'BirdLock' / 'updates'。若更新器调整目录,诊断包会静默漏掉更新日志而不报错。

建议:把该路径抽到不依赖 Qt 的公共函数,两处共用。

来源:2026-11-15 全仓只读审计,PR #7 未包含此项。 未在 Windows 实机复现,复现路径由代码审计推得。

Dominant language
Swift
Stars
2
Forks
2
Avg merge
1h 11m
Merged PRs (30d)
2

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cyandee/BirdLock

All issues in cyandee/BirdLock

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.