[低] FrameXform.valid 只写不读

Open Beginner friendly
#59 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Active
Tech stack
swift
Domain
tooling

Research direction

Start at Sources/BirdLockCore/Render/CompositionPlanner.swift lines 11, 16 and 245 to see how valid is initialised from hasData, then grep FrameXform across the repo to confirm nothing reads it. Read Sources/BirdLockCLI/main.swift:213,246 and Tests/BirdLockCoreTests/VideoStabilizationTests.swift to see whether the property leaks into encoded plan JSON, since removing it changes the Codable shape. Done means either the field is deleted with swift test passing and any serialized output still accepted, or a short note explains the planned use.

Written by the indexing model from the issue text.

Description

位置:Sources/BirdLockCore/Render/CompositionPlanner.swift:11、:16、:245;Sources/BirdLockCLI/main.swift:213,246;Tests/BirdLockCoreTests/VideoStabilizationTests.swift

现象:valid 在构造时写入(CompositionPlanner.swift:245 记录 hasData),但全仓没有任何读取。删除会改变 FrameXform 的 Codable 形态,因此没有在本次整改中处理。

建议:确认没有计划用途后删除,或补上使用它的逻辑(例如标记无数据帧)。

来源:2026-11-15 全仓只读审计,PR #7 未包含此项。

Dominant language
Swift
Stars
2
Forks
2
Avg merge
1h 11m
Merged PRs (30d)
2

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cyandee/BirdLock

All issues in cyandee/BirdLock

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.