Uncovered pre-existing branches in the executor and worker command
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
Research direction
Start by reading executor.py:278-280 and management/commands/threadmill.py at lines 114, 122-123, 125, 153-156, and 176-177. Run uv run pytest to reproduce the missing coverage, then add direct tests for each branch or confirm which unreachable branches can be removed. Done means the relevant branches are covered or deleted and the test suite passes.
Written by the indexing model from the issue text.
Description
Found by testJoe while adding coverage for the fair multi-queue rotation (codingjoe-fair-multi-queue-scheduling). All pre-existing, all untouched by that diff. Filed as one item because none of them is worth its own tracker entry.
executor.py:278-280— theEmpty/TimeoutErrorhandler inWorkerThread.run. Currently shadowed by theredis.py:297thread crash (see the sibling issue aboutNonepoll intervals), so it never runs in the suite.management/commands/threadmill.py:114— invalid-backendCommandError.management/commands/threadmill.py:122-123,125— invalid-log-formatCommandError.management/commands/threadmill.py:153-156—KeyboardInterruptshutdown branch.management/commands/threadmill.py:176-177— missing-inspector-dependencyCommandError.
Add direct tests for each, or delete the branches no caller can reach. uv run pytest reports them as missing today.
- Dominant language
- Python
- Stars
- 12
- Forks
- 1
- Avg merge
- 19h 11m
- Merged PRs (30d)
- 12
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from codingjoe/threadmill
-
Difficulty 2/5 Half a day Newbie friendliness 84/100
codingjoe/threadmill#52 ·
-
WorkerProcess passes None poll intervals to the backend, breaking acquire in the consumer thread Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
codingjoe/threadmill#53 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
codingjoe/threadmill#51 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
codingjoe/threadmill#47 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
codingjoe/threadmill#55 · 1 comment ·
All issues in codingjoe/threadmill
Similar issues
-
essnmx good first issue
Difficulty 1/5 Under an hour Newbie friendliness 95/100
-
[Feature] 奇物选择添加优先级 Open
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
syfoud/Simulated_Scepter#174 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Giskard-AI/giskard-oss#2840 · 1 comment ·
-
A claim comment carrying the issue number is silently declined while the workflow reports success Openarea: repo bug perceived difficulty: 2
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
yeti-platform/yeti#1380 ·