Three uncovered pre-existing spots on the monitoring and dashboard surface
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 64/100
Research direction
Start with the existing tests for services/email/dashboard/context_processors.py and the reputation dashboard views, then run the provided pytest command with coverage. Add a test for the context processor's anonymous, no-org path and rendering assertions for the cited fbl_report_detail.html and fbl_report_list.html spots; done when those behaviors are covered by assertions, since template coverage percentages are unreliable here.
Written by the indexing model from the issue text.
Description
Three pre-existing lines on the dashboard and reputation surfaces have no test.
Work reference: branch codingjoe-weekly-digest, commits 2ace45d2 to 6f28eacf, weekly sending digest. This work is from the superJoe crew. testJoe measured the two apps for that change, and these lines were already dark.
side quest:services/email/dashboard/context_processors.py:8return {}when no org is selected is uncovered. Pre-existing, not in this diff. [services/email/dashboard/context_processors.py]
side quest:reputation/fbl_report_detail.html lines 43, 51-54, 72-77, 81-88 are uncovered. Pre-existing, not in this diff. [services/email/reputation/templates/reputation/fbl_report_detail.html]
side quest:reputation/fbl_report_list.html line 68 is uncovered. Pre-existing, not in this diff. [services/email/reputation/templates/reputation/fbl_report_list.html]
Measured with uv run --group test pytest services/email/reputation services/email/dashboard --cov=services/email/reputation --cov=services/email/dashboard --cov-report=term-missing: 216 passed, 87 percent. Template line counts read 0 percent for every template in that run, including ones that a rendering test provably renders. The fbl template lines therefore want a rendering assertion, not a coverage number. The context processor line is the anonymous, no-org path.
Related: #329, #299, #292, #296, #297.
- Dominant language
- Python
- Stars
- 4
- Forks
- 0
- Avg merge
- 2h 40m
- Merged PRs (30d)
- 163
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from codingjoe/relay
-
enhancement real sec
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
codingjoe/relay#410 · 1 comment ·
Maintainers usually reply within 1 day
-
bug side quest
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
bug side quest
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
bug side quest
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
side quest test
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
btclib-org/btclib-node#2083 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Gathin23/cleanyourtv#2089 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
jxxghp/MoviePilot#7212 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
cli dx rust
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
NekomyaDev/nudge#278 ·
Maintainers usually reply within 1 day