Three uncovered pre-existing spots on the monitoring and dashboard surface

未关闭
#337 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
64/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
testing

调研方向

Start with the existing tests for services/email/dashboard/context_processors.py and the reputation dashboard views, then run the provided pytest command with coverage. Add a test for the context processor's anonymous, no-org path and rendering assertions for the cited fbl_report_detail.html and fbl_report_list.html spots; done when those behaviors are covered by assertions, since template coverage percentages are unreliable here.

由索引模型根据 Issue 内容生成。

描述

side quest test

Three pre-existing lines on the dashboard and reputation surfaces have no test.

Work reference: branch codingjoe-weekly-digest, commits 2ace45d2 to 6f28eacf, weekly sending digest. This work is from the superJoe crew. testJoe measured the two apps for that change, and these lines were already dark.

side quest: services/email/dashboard/context_processors.py:8 return {} when no org is selected is uncovered. Pre-existing, not in this diff. [services/email/dashboard/context_processors.py]

side quest: reputation/fbl_report_detail.html lines 43, 51-54, 72-77, 81-88 are uncovered. Pre-existing, not in this diff. [services/email/reputation/templates/reputation/fbl_report_detail.html]

side quest: reputation/fbl_report_list.html line 68 is uncovered. Pre-existing, not in this diff. [services/email/reputation/templates/reputation/fbl_report_list.html]

Measured with uv run --group test pytest services/email/reputation services/email/dashboard --cov=services/email/reputation --cov=services/email/dashboard --cov-report=term-missing: 216 passed, 87 percent. Template line counts read 0 percent for every template in that run, including ones that a rendering test provably renders. The fbl template lines therefore want a rendering assertion, not a coverage number. The context processor line is the anonymous, no-org path.

Related: #329, #299, #292, #296, #297.

主要语言
Python
星标
4
派生
0
平均合并
2 小时 30 分钟
30 天内合并 PR
165

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

codingjoe/relay 的其他 Issue

查看 codingjoe/relay 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。