Modify Conversation serializer to handle includes based on JSON API sideposting draft

Open
#1,624 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
frontend, web-dev

Research direction

Start by reviewing the serializer changes from #1597, which this issue identifies as a prerequisite, and read #1303 for the related implementation. Verify the JSON API sideposting draft and trace conversation creation alongside a message. Done means the generated tempId is emitted as temp-id in both the relationship identifier and json['included'], then posted to the API.

Written by the indexing model from the issue text.

Description

blocked

Problem

From https://github.com/json-api/json-api/pull/1197/files?short_path=571f6ce#diff-571f6cee9a492e0e177801c21a4b2b2a

When creating a conversation alongside a message, we need to generate a tempId for that conversation. The tempId needs to appear as temp-id both in the json['data']['relationship'] identifier as well as the json['included'] section and needs to be posted to the API.

References

Needs to be implemented together with #1303 https://github.com/code-corps/code-corps-api/issues/1303.

The code this needs to modify is in #1597, so this should be considered blocked until that is merged.

Dominant language
JavaScript
Stars
120
Forks
75
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from code-corps/code-corps-ember

All issues in code-corps/code-corps-ember

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.