Rewrite integration tests for team-member-test component

Open Beginner friendly
#1,613 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
frontend, testing

Research direction

Start with tests/integration/components/team-member-test.js and compare it with tests/pages/components/donations/create-donation.js and tests/integration/components/donations/create-donation-test.js. Review the ember-cli-page-objects quickstart and use the stated generator if needed. Done means the team-member-test component integration test uses a page object instead of jQuery selectors.

Written by the indexing model from the issue text.

Description

Problem

As of right now, tests/integration/components/team-member-test.js isn't utilizing ember-cli-page-objects, and instead is using jQuery to select elements.

References

#1606

Resources

  • What's a page object? [1,2]

  • Quickstart guide

  • See tests/pages/components/donations/create-donation.js and tests/integration/components/donations/create-donation-test.js for in-house examples of, respectively, a page object and the page object being utilized in an integration test.

  • To generate a page object, run ember generate page-object component/<component-name> in the project directory.

Dominant language
JavaScript
Stars
120
Forks
75
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from code-corps/code-corps-ember

All issues in code-corps/code-corps-ember

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.