Github SignUp/SignIn
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- authentication, frontend
Research direction
Start with the existing GitHub connect button on the user integration page, then trace the signup and login pages and the GitHub route. Review how the route updates the store and session, including the persisted redirected-from route, and check the linked API issue for the server-side behavior. Done means GitHub signup and sign-in buttons work and successful authentication redirects to the original destination.
Written by the indexing model from the issue text.
Description
Problem
We want to add github signup/sign in in addition to the github connect we currently have.
This can be done followingly
First, we add buttons to the UI
- Add a signup with github button to the signup page. This is basically the connect with github button on the user integration page, just with different test
- Add a sign in with github button to the login page, same as above
Considering the behavior of the button is about the same, we should rename the existing component and then rewrite it so it yields to content (so we can specify text/content ourselves).
Next, we modify our github route
Right now, it sends the code and the state to our API and pushes the returned user into the store.
We should modify this so it also signs the returned user into the session and, if that happens, does not redirect to the settings.integrations route and instead redirects to the redirected from route (should be persisted in the session).
That's it on ember
That should be all there is to it on the side of ember. We can expand later, by, for example, allowing users who signed up through github, to set their password, etc.
The rest is done on the API - https://github.com/code-corps/code-corps-api/issues/9#issuecomment-329185148
@JoshSmith Does this sound like it should be it, or am I missing something?
- Dominant language
- JavaScript
- Stars
- 120
- Forks
- 75
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from code-corps/code-corps-ember
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
code-corps/code-corps-ember#1616 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
code-corps/code-corps-ember#1613 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
code-corps/code-corps-ember#1612 ·
-
Difficulty: Medium Skill: ember-cli-page-object
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
code-corps/code-corps-ember#1063 · 1 reaction ·
-
greenkeeper
Difficulty 3/5 1-2 days Newbie friendliness 25/100
code-corps/code-corps-ember#1765 · 1 comment ·
All issues in code-corps/code-corps-ember
Similar issues
-
bug confirmed issue
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
open-webui/open-webui#30750 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Mend: dependency security vulnerability untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 70/100