Github SignUp/SignIn

未关闭

#1,373 创建于 2017年9月13日 1 条评论 0 个 reaction 已指派 0 人在 GitHub 查看

还没有人认领这个 Issue。

评估

难度: 4/5
预计耗时: 3-5 天
新手友好度: 35/100

Issue 类型: 功能
描述清晰度: 基本清楚
活跃度: 停滞
技术栈: javascript
领域: authentication, frontend

调研方向

从用户集成页面上现有的 GitHub 连接按钮开始，然后跟踪注册页、登录页和 GitHub 路由。检查该路由如何更新 store 和 session，包括持久化的重定向来源路由，并查看关联的 API issue 以了解服务端行为。当 GitHub 注册和登录按钮可以正常工作，且认证成功后会重定向到原始目标时，即表示完成。

由索引模型根据 Issue 内容生成。

描述

needs estimate

Problem

We want to add github signup/sign in in addition to the github connect we currently have.

This can be done followingly

First, we add buttons to the UI

Add a signup with github button to the signup page. This is basically the connect with github button on the user integration page, just with different test
Add a sign in with github button to the login page, same as above

Considering the behavior of the button is about the same, we should rename the existing component and then rewrite it so it yields to content (so we can specify text/content ourselves).

Next, we modify our github route

Right now, it sends the code and the state to our API and pushes the returned user into the store.

We should modify this so it also signs the returned user into the session and, if that happens, does not redirect to the settings.integrations route and instead redirects to the redirected from route (should be persisted in the session).

That's it on ember

That should be all there is to it on the side of ember. We can expand later, by, for example, allowing users who signed up through github, to set their password, etc.

The rest is done on the API - https://github.com/code-corps/code-corps-api/issues/9#issuecomment-329185148

@JoshSmith Does this sound like it should be it, or am I missing something?