Only task authors as well as project contributors or higher can edit task skills.

Open
#1,043 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
authorization, frontend

Research direction

Start in project/tasks/task.hbs and inspect the existing skill-button, skill-typeahead, and related-skills usage. Review acceptance/task-editing-test.js and the task page object in tests/pages/project/tasks/task.js, then run the relevant acceptance tests. Done means unauthorized users cannot assign or remove task skills while authorized users retain the editing UI.

Written by the indexing model from the issue text.

Description

blocked Difficulty: Easy needs clarification needs design

Problem

Right now on project/tasks/task.hbs, the UI to remove and add task skills is accessible by anyone.

We should change this so that only users who are able to edit tasks can interact with this part of the UI.

Subtasks

  • Wrap the skill-button collection as well as the skill-typeahead UI with an {{#if (can 'edit task' task)}} block
  • [ ] Put a {{related-skills}} component into the else` part of the block.
  • [ ] Fix any broken tests
  • [ ] Add an acceptance test to acceptance/task-editing-test.js along the lines of "skills cannot be assigned to/from a task if user is not able to".
  • [ ] Possibly: Add properties to tests/pages/project/tasks/task.js to support the above acceptance test. Something like rendersTaskSkillsList, rendersRelatedSkills, rendersSkillsTypeahead, etc.
Dominant language
JavaScript
Stars
120
Forks
75
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from code-corps/code-corps-ember

All issues in code-corps/code-corps-ember

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.