memory-systems example script: three upstream issues (text not stored, unstable embeddings, ignored time filter)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 55/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- python
- Domain
- documentation
Research direction
Read skills/memory-systems/scripts/memory_store.py alongside the skill's README to confirm which limits are already described. Note that the file is vendored byte-identical at a pinned upstream commit and is exercised only by the offline context-skills check, so the work is not editing it: either file the three findings upstream or document the limitations (text not persisted, salted hash() embeddings, ignored time_filter) in the skill README. Done means the chosen route is clear and the README states the limits or links the upstream report; confirm which option the maintainers want before writing.
Written by the indexing model from the issue text.
Description
skills/memory-systems/scripts/memory_store.py is vendored verbatim from muratcankoylan/Agent-Skills-for-Context-Engineering at 9ff0c99108b3 (MIT). It is an example script for the memory-systems skill. Only the offline context-skills check runs it, and no install or runtime path uses it.
An automated review found three medium issues in the upstream code:
add()does not keep the text.add(text, metadata)usestextonly to compute the embedding.search()then returnsmetadata["text"], falling back to"", so a caller that doesn't also put the text inmetadatagets empty strings back.- Embeddings change between runs. The placeholder embedding is seeded with Python's built-in
hash(). String hashing is salted per process (PYTHONHASHSEED), so the same text gives different vectors in different runs. That breaks the docstring's claim that identical texts always produce identical vectors, and anything persisted across runs. time_filteris ignored.retrieve_memories()acceptstime_filterand its docstring says results can be filtered by time, but the parameter is never used, so callers get unfiltered results.
Two low items were also noted: an unused json import, and the query vector's norm being recomputed inside the search loop.
We don't patch the vendored file here: it stays byte-identical to the pinned upstream commit. Options are to report these upstream and re-vendor once fixed, or to document the limits in the skill's README.
- Dominant language
- HTML
- Stars
- 347
- Forks
- 12
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 95
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from coco-research/coco
-
bug P2
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
coco-research/coco#539 ·
Maintainers usually reply within 1 day
-
bug P2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
coco-research/coco#538 ·
Maintainers usually reply within 1 day
-
bug P2
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
coco-research/coco#537 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
coco-research/coco#530 ·
Maintainers usually reply within 1 day
-
check-asset-counts: bare 149 tripwire collides with a real active-assets count of 149Possibly taken @aryankalantri claimed this 1 day ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
coco-research/coco#473 ·
Maintainers usually reply within 1 day
All issues in coco-research/coco
Similar issues
-
backlog-skill cat:docs documentation effort:s ready-for-agent sev:low
Difficulty 1/5 Under an hour Newbie friendliness 82/100
LucasSantana-Dev/Lucky#3284 ·
Maintainers usually reply within 1 day
-
Custom namespace instructions imply icon child classes are renamedPossibly taken @nemo-crypto claimed this today. Open
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
janitor-team/janitor#2592 ·
Maintainers usually reply within 1 day
-
documentation Peer Review
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Aeolus-Software/RealmForge#322 ·
Maintainers usually reply within 1 day