memory-systems example script: three upstream issues (text not stored, unstable embeddings, ignored time filter)

オープン
#528 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
2/5
見積もり時間
1〜3時間
初心者へのやさしさ
55/100
issue の種類
ドキュメント
明瞭さ
おおむね明確
活発さ
活発
技術スタック
python
領域
documentation

調査の方向性

Read skills/memory-systems/scripts/memory_store.py alongside the skill's README to confirm which limits are already described. Note that the file is vendored byte-identical at a pinned upstream commit and is exercised only by the offline context-skills check, so the work is not editing it: either file the three findings upstream or document the limitations (text not persisted, salted hash() embeddings, ignored time_filter) in the skill README. Done means the chosen route is clear and the README states the limits or links the upstream report; confirm which option the maintainers want before writing.

索引モデルが issue の本文から書いたものです。

説明

upstream

skills/memory-systems/scripts/memory_store.py is vendored verbatim from muratcankoylan/Agent-Skills-for-Context-Engineering at 9ff0c99108b3 (MIT). It is an example script for the memory-systems skill. Only the offline context-skills check runs it, and no install or runtime path uses it.

An automated review found three medium issues in the upstream code:

  1. add() does not keep the text. add(text, metadata) uses text only to compute the embedding. search() then returns metadata["text"], falling back to "", so a caller that doesn't also put the text in metadata gets empty strings back.
  2. Embeddings change between runs. The placeholder embedding is seeded with Python's built-in hash(). String hashing is salted per process (PYTHONHASHSEED), so the same text gives different vectors in different runs. That breaks the docstring's claim that identical texts always produce identical vectors, and anything persisted across runs.
  3. time_filter is ignored. retrieve_memories() accepts time_filter and its docstring says results can be filtered by time, but the parameter is never used, so callers get unfiltered results.

Two low items were also noted: an unused json import, and the query vector's norm being recomputed inside the search loop.

We don't patch the vendored file here: it stays byte-identical to the pinned upstream commit. Options are to report these upstream and re-vendor once fixed, or to document the limits in the skill's README.

主要言語
HTML
スター
347
フォーク
12
平均マージ
2日 16時間
マージ済み PR(30日)
95

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

coco-research/coco のほかの issue

coco-research/coco の issue をすべて見る

似ている issue

Documentation の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。