Running migration with umzug has some issues

Open
#19 6 comments 0 reactions 1 assignee View on GitHub

@benesch is already working on this.

Since Oct 11, 2017.

Assessment

This issue has not been assessed yet.

Description

When running the following migration

'use strict';

module.exports = {
 up: (query, types) => {
  query.addColumn('Users', 'lastName', types.STRING);
 },
 down: (query, types) => {
  query.removeColumn('Users', 'lastName');
 },
};

This error is thrown SequelizeDatabaseError: database "public" does not exist
the query that it attempted to ran was this:

Executing (default): ALTER TABLE "public"."Users" ADD COLUMN "lastName" VARCHAR(255);

After digging into the code a little bit I think i tracked this down to this line here in sequelize
https://github.com/sequelize/sequelize/blob/master/lib/dialects/abstract/query-generator.js#L26

You can see they call this function in the postgres query-generator dialect on this line
https://github.com/sequelize/sequelize/blob/master/lib/dialects/postgres/query-generator.js#L241

Versions:
Cockroachdb: CCL v1.1.0-rc.1 @ 2017/10/05 15:33:25 (go1.8.3)
sequelize-cockroachdb: 1.0.2
umzug: 2.0.1

Dominant language
JavaScript
Stars
54
Forks
18
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cockroachdb/sequelize-cockroachdb

All issues in cockroachdb/sequelize-cockroachdb

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.