Enum not working after this commit in Sequelize project

Open
#153 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
databases

Research direction

Start in query-generator.js and compare the enum handling with commit 6d9a58e7556de614133c2d16ba6ee8e8cebd5fa0. Run the enum tests exercised by createTable and review the linked Sequelize issue for context; done means those tests pass with CockroachDB without using the unsupported SQL syntax.

Written by the indexing model from the issue text.

Description

Hi.

After this change in query-generator.js in commit: https://github.com/sequelize/sequelize/commit/6d9a58e7556de614133c2d16ba6ee8e8cebd5fa0
the enum tests in createTable are failing.
Enums are no longer working.

The reason is that this commit uses an SQL syntax that is not supported by CockroachDB (do begin...)

Opened an issue in the core Sequelize project as well: https://github.com/sequelize/sequelize/issues/16191

Dominant language
JavaScript
Stars
54
Forks
18
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cockroachdb/sequelize-cockroachdb

All issues in cockroachdb/sequelize-cockroachdb

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.