[quality] e2e coverage failure reports say 'run null; status unknown' for every error raised after the manifest is read
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions, javascript, node.js
Research direction
Start with the catch block in tests/tools/e2e-coverage-report.mjs and the CLI cases in tests/e2e-coverage-report.test.mjs; run npm run test:unit:coverage to see the existing coverage tests. Add cases for readable passed and failed manifests that trigger a plain Error, plus the absent or unreadable manifest case. Done means failure reports retain manifest runId/runStatus when available, preserve failed/cancelled status, and still use null fields when no manifest can be read.
Written by the indexing model from the issue text.
Description
Finding
When tests/tools/e2e-coverage-report.mjs fails for any reason after the run
manifest has been read and validated, the failure report it publishes claims it
does not know which run it was rendering — even though it does.
main() builds its fallback report from fields that only CoverageReportError
carries (tests/tools/e2e-coverage-report.mjs:688-696):
status:
error.runStatus === 'failed' || error.runStatus === 'cancelled'
? error.runStatus
: 'tooling-error',
runId: error.runId ?? null,
runStatus: error.runStatus ?? null,
Only four throw sites construct a CoverageReportError, and all four are the
run-status/capture guards near the top of collectE2ECoverage
(lines 461, 467, 484). Every later failure is a plain Error:
coverage run contains incomplete temporary artifacts(line 474)unexpected coverage artifact kind in <entry>(line 490)coverage artifact <entry> belongs to another run(line 493)No src/** coverage was attributable(line 619)- every per-script conversion failure —
source map escapes build directory
(162, 166),generated source has no sourceMappingURL comment(178),
generated source hash mismatch(369), and the map-resolution throws at
211, 222, 229, 260, 344, 351, 361.
For all of those, error.runId and error.runStatus are undefined, so
renderE2ECoverageReport (line 626) emits:
E2E coverage: tooling-error (run null; status unknown)
Why it matters
.github/workflows/ci.yml:236-249 cats coverage/e2e/report.txt straight into
$GITHUB_STEP_SUMMARY, and that header line is the whole diagnostic. A reader
of a red End-to-end coverage job cannot tell from it whether
- the Playwright run itself failed and the reporter is faithfully reporting a
sealed-failedrun, or - the Playwright run passed and only the reporting step broke.
Those two have opposite remedies, and the artifact erases the distinction at
exactly the moment it is needed. The same null lands in report.json, so
anything consuming the JSON inherits it.
There is a second, smaller consequence: a run sealed failed or cancelled
that then trips one of the plain-Error sites is reported with
status: 'tooling-error' rather than failed/cancelled, because the ternary
above also reads error.runStatus. The report blames the tooling for a test
failure.
Reproduction
At 900592b, render any sealed-passed run whose scripts cannot be attributed
to the local build/ — e.g. a published e2e-coverage artifact unpacked next
to a different build:
$ node tests/tools/e2e-coverage-run.mjs seal --dir "$RUN_DIR" --status passed
{"schemaVersion":1,...,"runId":"local1","status":"passed",...}
$ npm run report:e2e:coverage -- --input "$RUN_DIR" --build build --text out.txt
$ head -1 out.txt
E2E coverage: tooling-error (run null; status unknown)
The manifest on disk says "runId": "local1", "status": "passed". The report
says null / unknown.
Evidence and provenance
- Unit:
npm run test:unit:coverage(TZ=UTC node tests/tools/coverage-report.mjs,
node v26.10.0), local, revision900592b—tests/tools/e2e-coverage-report.mjs
100.00% lines / 90.68% regions. Themain()catch block is executed by the
existing CLI tests, but no test asserts therunId/runStatusit writes for
a non-CoverageReportErrorfailure, which is why the defect is invisible to
the suite. - Reproduced locally twice at
900592bas shown above, once against a freshly
sealed local run and once against thee2e-coverageartifact of CI run
37164361552. - This is a reporting-fidelity defect, not a coverage gap: no claim is made
here about any source path's end-to-end coverage.
Recommendation
Fall back to the run manifest in main()'s catch, so the published failure
report names the run whenever the manifest is readable:
} catch (error) {
// Only the run-status guards raise CoverageReportError; every later
// failure is a plain Error, so re-read the manifest rather than publish a
// report that cannot say whether the run passed or the tooling broke.
const run = await readCoverageRun(resolve(options.input)).catch(() => null);
const runStatus = error.runStatus ?? run?.status ?? null;
const failure = {
schemaVersion: 2,
kind: ERROR_KIND,
status:
runStatus === 'failed' || runStatus === 'cancelled'
? runStatus
: 'tooling-error',
runId: error.runId ?? run?.runId ?? null,
runStatus,
...
readCoverageRun is already imported at line 14, and the .catch(() => null)
keeps an unreadable or absent manifest behaving exactly as it does today.
Cover it in tests/e2e-coverage-report.test.mjs with two CLI cases:
- a sealed-
passedrun that trips a plain-Errorsite, asserting the written
report carries thatrunIdandrunStatus: 'passed'with
status: 'tooling-error'; - a sealed-
failedrun that trips the same site, assertingstatusis
'failed'rather than'tooling-error'.
Coordination
The fix lands only in main() (tests/tools/e2e-coverage-report.mjs:674-713).
- #1040 edits the same file at
convertScriptand insidecollectE2ECoverage(script-root resolution); it
does not touchmain()or anythrowsite. - #1051 edits
getRegionCoverage
and the union; it does not touchmain().
No open PR claims this function, so the change is disjoint from both.
Completion criteria
- A failure report for a readable manifest carries the run's real
runIdandrunStatus - A run sealed
failed/cancelledis reported with that status, nottooling-error - An unreadable or absent manifest still yields
runId: null/runStatus: null -
tests/e2e-coverage-report.test.mjscovers all three
Priority
- Impact: medium (CI's only published e2e diagnostic misattributes test failures to the tooling)
- Effort: low
🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5n31 | SHA: 900592b
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 2
- Avg merge
- 22h 43m
- Merged PRs (30d)
- 371
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cncf/endusers
-
[quality] useFocusTrap's Shift+Tab wrap and non-Tab/non-Escape key arms are never driven end to endPossibly taken @hivecommons-hive claimed this today. Openagent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
[quality] parentOf's empty-prefix fallback in e2e-data-fixtures.cjs is the file's only uncovered regionPossibly taken @hivecommons-hive claimed this today. Openagent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
[quality] the member directory freshness note is rendered from three scheduled data files and asserted by no e2e testPossibly taken @hivecommons-hive claimed this today. Openagent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
[quality] e2e reporter's source-reference resolution has five untested branches (repoRelative root, bare webpack authority, absent sourcesContent)Possibly taken @hivecommons-hive claimed this 1 day ago. Openagent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
[quality] CaseStudies' undated-study comparator fallbacks have no end-to-end coveragePossibly taken @hivecommons-hive claimed this 1 day ago. Openagent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
Similar issues
-
automated issue report
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
lirantal/discoprint#36 ·
Maintainers usually reply within 1 day
-
accepting PR Content:HTML
Difficulty 1/5 Under an hour Newbie friendliness 88/100
mdn/content#45988 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
txn2/mcp-data-platform#2030 ·
Maintainers usually reply within 1 day
-
ci hacktoberfest help wanted size/small type/bug type/docs type/enhancement up-for-grabs
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Redo-San/RedoSan-Authenticity#527 ·
Maintainers usually reply within 1 day