[quality] e2e coverage failure reports say 'run null; status unknown' for every error raised after the manifest is read
メンテナーはふだん 1 日以内に返信
評価
- 難易度
- 2/5
- 見積もり時間
- 1〜3時間
- 初心者へのやさしさ
- 78/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- github-actions, javascript, node.js
調査の方向性
tests/tools/e2e-coverage-report.mjs の catch ブロックと tests/e2e-coverage-report.test.mjs の CLI ケースから始め、npm run test:unit:coverage を実行して既存のカバレッジテストを確認します。単純な Error を発生させる、読み取り可能な成功および失敗マニフェストのケースに加え、マニフェストが存在しない、または読み取り不能なケースを追加します。完了条件は、エラーレポートが利用可能な場合にマニフェストの runId/runStatus を保持し、failed/cancelled ステータスを維持し、マニフェストを読み取れない場合は引き続き null フィールドを使用することです。
索引モデルが issue の本文から書いたものです。
説明
Finding
When tests/tools/e2e-coverage-report.mjs fails for any reason after the run
manifest has been read and validated, the failure report it publishes claims it
does not know which run it was rendering — even though it does.
main() builds its fallback report from fields that only CoverageReportError
carries (tests/tools/e2e-coverage-report.mjs:688-696):
status:
error.runStatus === 'failed' || error.runStatus === 'cancelled'
? error.runStatus
: 'tooling-error',
runId: error.runId ?? null,
runStatus: error.runStatus ?? null,
Only four throw sites construct a CoverageReportError, and all four are the
run-status/capture guards near the top of collectE2ECoverage
(lines 461, 467, 484). Every later failure is a plain Error:
coverage run contains incomplete temporary artifacts(line 474)unexpected coverage artifact kind in <entry>(line 490)coverage artifact <entry> belongs to another run(line 493)No src/** coverage was attributable(line 619)- every per-script conversion failure —
source map escapes build directory
(162, 166),generated source has no sourceMappingURL comment(178),
generated source hash mismatch(369), and the map-resolution throws at
211, 222, 229, 260, 344, 351, 361.
For all of those, error.runId and error.runStatus are undefined, so
renderE2ECoverageReport (line 626) emits:
E2E coverage: tooling-error (run null; status unknown)
Why it matters
.github/workflows/ci.yml:236-249 cats coverage/e2e/report.txt straight into
$GITHUB_STEP_SUMMARY, and that header line is the whole diagnostic. A reader
of a red End-to-end coverage job cannot tell from it whether
- the Playwright run itself failed and the reporter is faithfully reporting a
sealed-failedrun, or - the Playwright run passed and only the reporting step broke.
Those two have opposite remedies, and the artifact erases the distinction at
exactly the moment it is needed. The same null lands in report.json, so
anything consuming the JSON inherits it.
There is a second, smaller consequence: a run sealed failed or cancelled
that then trips one of the plain-Error sites is reported with
status: 'tooling-error' rather than failed/cancelled, because the ternary
above also reads error.runStatus. The report blames the tooling for a test
failure.
Reproduction
At 900592b, render any sealed-passed run whose scripts cannot be attributed
to the local build/ — e.g. a published e2e-coverage artifact unpacked next
to a different build:
$ node tests/tools/e2e-coverage-run.mjs seal --dir "$RUN_DIR" --status passed
{"schemaVersion":1,...,"runId":"local1","status":"passed",...}
$ npm run report:e2e:coverage -- --input "$RUN_DIR" --build build --text out.txt
$ head -1 out.txt
E2E coverage: tooling-error (run null; status unknown)
The manifest on disk says "runId": "local1", "status": "passed". The report
says null / unknown.
Evidence and provenance
- Unit:
npm run test:unit:coverage(TZ=UTC node tests/tools/coverage-report.mjs,
node v26.10.0), local, revision900592b—tests/tools/e2e-coverage-report.mjs
100.00% lines / 90.68% regions. Themain()catch block is executed by the
existing CLI tests, but no test asserts therunId/runStatusit writes for
a non-CoverageReportErrorfailure, which is why the defect is invisible to
the suite. - Reproduced locally twice at
900592bas shown above, once against a freshly
sealed local run and once against thee2e-coverageartifact of CI run
37164361552. - This is a reporting-fidelity defect, not a coverage gap: no claim is made
here about any source path's end-to-end coverage.
Recommendation
Fall back to the run manifest in main()'s catch, so the published failure
report names the run whenever the manifest is readable:
} catch (error) {
// Only the run-status guards raise CoverageReportError; every later
// failure is a plain Error, so re-read the manifest rather than publish a
// report that cannot say whether the run passed or the tooling broke.
const run = await readCoverageRun(resolve(options.input)).catch(() => null);
const runStatus = error.runStatus ?? run?.status ?? null;
const failure = {
schemaVersion: 2,
kind: ERROR_KIND,
status:
runStatus === 'failed' || runStatus === 'cancelled'
? runStatus
: 'tooling-error',
runId: error.runId ?? run?.runId ?? null,
runStatus,
...
readCoverageRun is already imported at line 14, and the .catch(() => null)
keeps an unreadable or absent manifest behaving exactly as it does today.
Cover it in tests/e2e-coverage-report.test.mjs with two CLI cases:
- a sealed-
passedrun that trips a plain-Errorsite, asserting the written
report carries thatrunIdandrunStatus: 'passed'with
status: 'tooling-error'; - a sealed-
failedrun that trips the same site, assertingstatusis
'failed'rather than'tooling-error'.
Coordination
The fix lands only in main() (tests/tools/e2e-coverage-report.mjs:674-713).
- #1040 edits the same file at
convertScriptand insidecollectE2ECoverage(script-root resolution); it
does not touchmain()or anythrowsite. - #1051 edits
getRegionCoverage
and the union; it does not touchmain().
No open PR claims this function, so the change is disjoint from both.
Completion criteria
- A failure report for a readable manifest carries the run's real
runIdandrunStatus - A run sealed
failed/cancelledis reported with that status, nottooling-error - An unreadable or absent manifest still yields
runId: null/runStatus: null -
tests/e2e-coverage-report.test.mjscovers all three
Priority
- Impact: medium (CI's only published e2e diagnostic misattributes test failures to the tooling)
- Effort: low
🐝 Hive Agent: quality | Instance: hosted-available-lke648397-260827-5n31 | SHA: 900592b
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88
- 主要言語
- JavaScript
- スター
- 0
- フォーク
- 2
- 平均マージ
- 22時間 21分
- マージ済み PR(30日)
- 404
環境構築
このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。
- Dockerfile・Docker Compose ファイルなし
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
cncf/endusers のほかの issue
-
agent/scanner bug hive/hosted-available-lke648397-260827-5n31
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
-
[quality] the member-dialog logo-less e2e case reads data/members.json, so a landscape refresh can silently retire it対応中かも @hivecommons-hive が今日担当しました。 オープンagent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5n31 quality testing
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100
メンテナーはふだん 1 日以内に返信
-
agent/guide documentation hive/hosted-available-lke648397-260827-5n31
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
-
agent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5n31 quality testing
難易度 2/5 1〜3時間 初心者へのやさしさ 72/100
メンテナーはふだん 1 日以内に返信
-
agent/guide documentation hive/hosted-available-lke648397-260827-5n31
難易度 1/5 1時間未満 初心者へのやさしさ 82/100
メンテナーはふだん 1 日以内に返信
似ている issue
-
bug user-priority/P2
難易度 1/5 1時間未満 初心者へのやさしさ 92/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1時間未満 初心者へのやさしさ 78/100
opencart/opencart#15763 · コメント 2 件 · リアクション 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
neondatabase/agent-skills#139 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
Effect-TS/effect#8881 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
mail processing verified
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
メンテナーはふだん 7 日以内に返信