404 responses are still written to the cache

Open
  • Is something wrong?
#278 2 comments 0 reactions 2 assignees View on GitHub

@michalkcloudinay is already working on this.

Since Mar 15, 2021.

Assessment

This issue has not been assessed yet.

Description

bug

Bug report for Cloudinary iOS SDK

Before proceeding, please update to latest version and test if the issue persists

Describe the bug in a sentence or two.

When the cloudinary URL request fails with a 404, the downloadImageAndCacheIt function still attempts to write a 0 byte file to the cache.

Issue Type (Can be multiple)

[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[x] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[ ] Other (Specify)

Steps to reproduce

Simply call CLDDownloader.fetchImage(_:_:completionHandler:) with an invalid URL.

Error screenshots or Stack Trace (if applicable)

The following error is raised:

        {
        "error_code" = "-7001";
        "error_domain" = "com.cloudinary.error";
        "user_info" =         {
            NSLocalizedFailureReason = "Failed creating an image from the received data.";
        };

There was no received data.
image

Build/Dependency management

[x] Cocoa-Pods
[ ] Carthage
[ ] Manual import
[ ] Other (Specify)

Is the issue reproducible only on a specific device?

[x] No
[ ] Yes (specify model + iOS version)

Versions and Libraries (fill in the version numbers)

iOS Cloudinary SDK version - 2.9.0
OSX (on the dev environment) - 10.15.6 (19G73)
XCode - 12.1 (12A7403)
Swift - 5
Target iOS - 14.1

Dominant language
Swift
Stars
169
Forks
107
No merged PRs in 30d

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from cloudinary/cloudinary_ios

All issues in cloudinary/cloudinary_ios

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.