404 responses are still written to the cache

未關閉
#278 2 則留言 0 個 reaction 已指派 2 人 在 GitHub 檢視

@michalkcloudinay 已經在處理了。

開始於 2021年3月15日。

評估

這個 Issue 還沒有評估資料。

描述

bug

Bug report for Cloudinary iOS SDK

Before proceeding, please update to latest version and test if the issue persists

Describe the bug in a sentence or two.

When the cloudinary URL request fails with a 404, the downloadImageAndCacheIt function still attempts to write a 0 byte file to the cache.

Issue Type (Can be multiple)

[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[x] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[ ] Other (Specify)

Steps to reproduce

Simply call CLDDownloader.fetchImage(_:_:completionHandler:) with an invalid URL.

Error screenshots or Stack Trace (if applicable)

The following error is raised:

        {
        "error_code" = "-7001";
        "error_domain" = "com.cloudinary.error";
        "user_info" =         {
            NSLocalizedFailureReason = "Failed creating an image from the received data.";
        };

There was no received data.
image

Build/Dependency management

[x] Cocoa-Pods
[ ] Carthage
[ ] Manual import
[ ] Other (Specify)

Is the issue reproducible only on a specific device?

[x] No
[ ] Yes (specify model + iOS version)

Versions and Libraries (fill in the version numbers)

iOS Cloudinary SDK version - 2.9.0
OSX (on the dev environment) - 10.15.6 (19G73)
XCode - 12.1 (12A7403)
Swift - 5
Target iOS - 14.1

主要語言
Swift
星號
169
分支
107
PR 合併指標
30 天內沒有已合併 PR

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 有 Pull Request 範本
  • 沒有貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

cloudinary/cloudinary_ios 的其他 Issue

查看 cloudinary/cloudinary_ios 的全部 Issue

相似的 Issue

更多 Swift Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。