WhatsApp isn't properly rendering our invite links anymore
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #8825 by @Hocuri — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
Research direction
The payload names no source file, so start by finding where the Delta Chat invite link is built in the Rust core and how its query parameters, especially the r= addresses, are encoded. Generate an invite link and check whether the @ in the r= value is written as-is. Done when the encoded link uses %40 for @ and the added tests pass.
Written by the indexing model from the issue text.
Description
This is a Delta Chat invite link: https://i.delta.chat/#CFAE4957FFEB8529CC1A5CF568D0EFE4139D5749&v=3&x=8lJEkOodZ01W-Xz5sOvAI1JN&i=XonKX2YYHM14I5c-PBj3YAED&s=Pc4aW8eePr_lO1OFnwUJ5fVB&a=pbkwwo8z7%40nine.testrun.org&[email protected],13xe893jx%40tarpit.fun&n=Alice&g=Great+group
It's linkified correctly on Github, but WhatsApp makes only part of the link clickable, so that the inviter name gets lost. A group invite link additionally loses the group name and gets converted into a 1:1 invite.
This is how it looks:
When I replace the @ with %40, it gets linkified correctly:
Apparently, WhatsApp tries to be smart and assumes that if there is an @ in the link, it's almost over, and treats any non-ascii character as the end of the link.
...So, if we want our links to render correctly on WhatsApp, I guess we do need to replace @ with %40. That's a very simple one-line fix (plus tests). It will just make the links look a little bit uglier.
- Dominant language
- Rust
- Stars
- 937
- Forks
- 150
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 90
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from chatmail/core
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 50/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 54/100
chatmail/core#8814 · 3 comments · 1 reaction ·
Maintainers usually reply within 1 day
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
needs: triage type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
area:docs documentation P3
Difficulty 1/5 Under an hour Newbie friendliness 88/100
Raaif-Yousuf/Wingman#837 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
storytold/photocraft#6759 ·
Maintainers usually reply within 1 day