fix renamed columns in heatmap mat views

Open
#1,104 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
python

Research direction

Start with the heatmap mat view queries and column renaming changes discussed in pull request #1086. Trace where the columns are first renamed and where they are renamed back, then check whether the original query names can be preserved. Done means the mat views no longer use redundant renaming and still show the expected columns.

Written by the indexing model from the issue text.

Description

technical debt

During the mat view PR, some column names were changed and then code was added to un-rename them later.

Thats just unnecessary.

unfortunately i think some of this goes all the way back to a translation error when porting things to the mat views.

We need to go back and fix this so the code doesnt become random spaghetti of renaming things.

Also we should fix this before these views get upstreamed into augur, or the temporary fix will become more permanent

example:

We dont need to rename these columns again we can just undo where they were renamed the first time (it happened in this PR when the queries were uncommented)

Originally posted by @MoralCode in https://github.com/oss-aspen/8Knot/pull/1086#discussion_r2942029731

Dominant language
Python
Stars
80
Forks
92
Avg merge
1d 11h
Merged PRs (30d)
13

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from chaoss/8Knot

All issues in chaoss/8Knot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.