validation: two tests fail on sqlglot 30.19.0, the declared minimum
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start with the sqlglot version declaration in validation/validate.py and the two tests added in #647 under validation/tests/. Reproduce the failures with sqlglot 30.19.0, then check the suite with the proposed minimum of 30.29.0. Done when the declared minimum covers both tests and the validation test suite passes at that version.
Written by the indexing model from the issue text.
Description
validation/validate.py declares sqlglot>=30.19.0. On that version two of the tests added in #647 fail on main (74a26be):
uv run --no-project --with pytest --with pyyaml --with jsonschema --with "sqlglot==30.19.0" -m pytest validation/tests/
FAILED test_rejects_a_dialect_sql_statement_used_as_an_expression[snowflake-list]
FAILED test_accepts_keyword_column_expressions_in_dialect[desc-dot-bigquery]
2 failed, 748 passed, 1 skipped
snowflake-listexpectsLIST @stageto be rejected as a LIST STAGE statement. sqlglot up to 30.21.0 parses it as an aliased expression, so the validator returns no error. From 30.22.0 it parses asListStageand the test passes.desc-dot-bigqueryexpectsdesc.xto be accepted in BigQuery. Up to 30.27.0 the validator returns "Invalid expression / Unexpected token. Line 1, Col: 11." From 30.29.0 it accepts it.
I ran the suite on 30.19.0, 30.20.0, 30.21.0, 30.22.0, 30.25.0, 30.26.0, 30.27.0, 30.29.0, 30.30.0 and 30.33.0 (there is no 30.28.0). The first three fail both tests, the next four fail desc-dot-bigquery and the last three give 750 passed, 1 skipped. CI installs the latest sqlglot, so it does not run into this.
I can open a PR that raises the declared minimum to sqlglot>=30.29.0.
- Dominant language
- Python
- Stars
- 2.7k
- Forks
- 353
- Avg merge
- 3d 19h
- Merged PRs (30d)
- 86
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/ossie
-
needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 52/100
Maintainers usually reply within 1 day
-
validation: field reference resolution is case-insensitive but name uniqueness is case-sensitivePossibly taken @MikeNitsenko claimed this 6 days ago. Openneeds-triage
Difficulty 5/5 Over a week Newbie friendliness 25/100
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/ossie#710 · 6 comments ·
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 25/100
apache/ossie#707 · 3 comments ·
Maintainers usually reply within 1 day
-
needs-triage
Difficulty 5/5 Over a week Newbie friendliness 30/100
apache/ossie#694 · 3 comments ·
Maintainers usually reply within 1 day
Similar issues
-
integration: media_player
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
home-assistant/core#193344 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
daniel-ospina/tortoise#13607 ·
Maintainers usually reply within 1 day
-
documentation priority: medium
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 66/100
Robin-IA/Congressional-Letters-Dev#1347 ·
Maintainers usually reply within 1 day